From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
To: Jamal Hadi Salim <jhs@mojatatu•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org, daniel@iogearbox•net, xiyou.wangcong@gmail•com
Subject: Re: [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address
Date: Sat, 2 Jul 2016 17:16:50 +0200 [thread overview]
Message-ID: <5777DAE2.4000702@cumulusnetworks.com> (raw)
In-Reply-To: <1467470065-17613-1-git-send-email-jhs@emojatatu.com>
On 02/07/16 16:34, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu•com>
>
> Often redirecting or mirroring requires that we set the dstMAC address
> of the target device. While it is possible to pipe to a pedit action,
> this patch obsoletes the need for that. This is a justified feature because
> the dst MAC addresses rewrite is such a common use case.
>
> Sample usage:
> sudo $TC filter add dev $ETH parent 1: protocol ip prio 10 \
> u32 match ip protocol 1 0xff flowid 1:2 \
> action mirred egress redirect dev $SPANPORT dst 02:15:15:15:15:15
>
> This will match all icmp packets going out on dev $ETH and
> redirect them to dev $SPANPORT while setting their dst MAC address
> to 02:15:15:15:15:15
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu•com>
> ---
> include/net/tc_act/tc_mirred.h | 4 +++-
> include/uapi/linux/tc_act/tc_mirred.h | 7 ++++---
> net/sched/act_mirred.c | 24 +++++++++++++++++++++++-
> 3 files changed, 30 insertions(+), 5 deletions(-)
>
LGTM, thanks!
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
next prev parent reply other threads:[~2016-07-02 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 14:34 [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address Jamal Hadi Salim
2016-07-02 15:16 ` Nikolay Aleksandrov [this message]
2016-07-02 16:58 ` Cong Wang
2016-07-02 21:38 ` Jamal Hadi Salim
2016-07-04 15:25 ` Jiri Pirko
2016-07-04 22:14 ` David Miller
2016-07-05 11:04 ` Jamal Hadi Salim
2016-07-05 18:19 ` Cong Wang
2016-07-06 10:02 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5777DAE2.4000702@cumulusnetworks.com \
--to=nikolay@cumulusnetworks$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox