From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: David Miller <davem@davemloft•net>,
Linux Kernel Network Developers <netdev@vger•kernel.org>,
Daniel Borkmann <daniel@iogearbox•net>,
nikolay@cumulusnetworks•com
Subject: Re: [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address
Date: Sat, 2 Jul 2016 17:38:36 -0400 [thread overview]
Message-ID: <5778345C.1060201@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpXpkUo2H=Yndb4u63yKk6jNBbxYynmWtQRGhw6SAVUZrA@mail.gmail.com>
On 16-07-02 12:58 PM, Cong Wang wrote:
> On Sat, Jul 2, 2016 at 7:34 AM, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
>> From: Jamal Hadi Salim <jhs@mojatatu•com>
>>
>> Often redirecting or mirroring requires that we set the dstMAC address
>> of the target device. While it is possible to pipe to a pedit action,
>> this patch obsoletes the need for that. This is a justified feature because
>> the dst MAC addresses rewrite is such a common use case.
>
> Maybe, instead of allowing to set arbitrary MAC address, how about
> just allow setting to the MAC address of the target device?
You cant discover the remote MAC address; I have a wire
connected between two machines. I set it to the MAC address
of the remote machine i know of. And there are times I really
want to set it to some arbitrary values (although that is more
test mode than production).
cheers,
jamal
> If so we only need a boolean flag for user-space.
>
> IOW, do we really need such flexibility?
>
next prev parent reply other threads:[~2016-07-02 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 14:34 [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address Jamal Hadi Salim
2016-07-02 15:16 ` Nikolay Aleksandrov
2016-07-02 16:58 ` Cong Wang
2016-07-02 21:38 ` Jamal Hadi Salim [this message]
2016-07-04 15:25 ` Jiri Pirko
2016-07-04 22:14 ` David Miller
2016-07-05 11:04 ` Jamal Hadi Salim
2016-07-05 18:19 ` Cong Wang
2016-07-06 10:02 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5778345C.1060201@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox