From: Daniel Borkmann <daniel@iogearbox•net>
To: Daniel Mack <daniel@zonque•org>, ast@fb•com
Cc: davem@davemloft•net, netdev@vger•kernel.org,
roszenrami@gmail•com, cgroups@vger•kernel.org
Subject: Re: [PATCH] bpf: cgroup: fix documentation of __cgroup_bpf_update()
Date: Mon, 28 Nov 2016 14:03:21 +0100 [thread overview]
Message-ID: <583C2B19.7010506@iogearbox.net> (raw)
In-Reply-To: <1480331099-20216-1-git-send-email-daniel@zonque.org>
On 11/28/2016 12:04 PM, Daniel Mack wrote:
> There's a 'not' missing in one paragraph. Add it.
>
> Signed-off-by: Daniel Mack <daniel@zonque•org>
> Reported-by: Rami Rosen <roszenrami@gmail•com>
> Fixes: 3007098494be ("cgroup: add support for eBPF programs")
Small nit in subject: s/[PATCH]/[PATCH net-next]/
> kernel/bpf/cgroup.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c
> index a0ab43f..b708e6e 100644
> --- a/kernel/bpf/cgroup.c
> +++ b/kernel/bpf/cgroup.c
> @@ -70,9 +70,9 @@ void cgroup_bpf_inherit(struct cgroup *cgrp, struct cgroup *parent)
> * releases the one that is currently attached, if any. @prog is then made
> * the effective program of type @type in that cgroup.
> *
> - * If @prog is %NULL, the currently attached program of type @type is released,
> - * and the effective program of the parent cgroup (if any) is inherited to
> - * @cgrp.
> + * If @prog is not %NULL, the currently attached program of type @type is
> + * released, and the effective program of the parent cgroup (if any) is
> + * inherited to @cgrp.
Both paragraphs for __cgroup_bpf_update() currently say:
[...]
* If @prog is %NULL, this function attaches a new program to the cgroup and
* releases the one that is currently attached, if any. @prog is then made
* the effective program of type @type in that cgroup.
*
* If @prog is %NULL, the currently attached program of type @type is released,
* and the effective program of the parent cgroup (if any) is inherited to
* @cgrp.
[...]
It looks to me that you are 'fixing' the wrong location. First paragraph is
actually missing a "not", which would then also align with what the code does.
next prev parent reply other threads:[~2016-11-28 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 11:04 [PATCH] bpf: cgroup: fix documentation of __cgroup_bpf_update() Daniel Mack
2016-11-28 13:03 ` Daniel Borkmann [this message]
[not found] ` <583C2B19.7010506-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2016-11-28 13:07 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583C2B19.7010506@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ast@fb$(echo .)com \
--cc=cgroups@vger$(echo .)kernel.org \
--cc=daniel@zonque$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roszenrami@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox