* [PATCH] bpf: cgroup: fix documentation of __cgroup_bpf_update()
@ 2016-11-28 11:04 Daniel Mack
2016-11-28 13:03 ` Daniel Borkmann
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mack @ 2016-11-28 11:04 UTC (permalink / raw)
To: ast; +Cc: davem, netdev, roszenrami, cgroups, Daniel Mack
There's a 'not' missing in one paragraph. Add it.
Signed-off-by: Daniel Mack <daniel@zonque•org>
Reported-by: Rami Rosen <roszenrami@gmail•com>
Fixes: 3007098494be ("cgroup: add support for eBPF programs")
---
kernel/bpf/cgroup.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c
index a0ab43f..b708e6e 100644
--- a/kernel/bpf/cgroup.c
+++ b/kernel/bpf/cgroup.c
@@ -70,9 +70,9 @@ void cgroup_bpf_inherit(struct cgroup *cgrp, struct cgroup *parent)
* releases the one that is currently attached, if any. @prog is then made
* the effective program of type @type in that cgroup.
*
- * If @prog is %NULL, the currently attached program of type @type is released,
- * and the effective program of the parent cgroup (if any) is inherited to
- * @cgrp.
+ * If @prog is not %NULL, the currently attached program of type @type is
+ * released, and the effective program of the parent cgroup (if any) is
+ * inherited to @cgrp.
*
* Then, the descendants of @cgrp are walked and the effective program for
* each of them is set to the effective program of @cgrp unless the
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bpf: cgroup: fix documentation of __cgroup_bpf_update()
2016-11-28 11:04 [PATCH] bpf: cgroup: fix documentation of __cgroup_bpf_update() Daniel Mack
@ 2016-11-28 13:03 ` Daniel Borkmann
[not found] ` <583C2B19.7010506-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Borkmann @ 2016-11-28 13:03 UTC (permalink / raw)
To: Daniel Mack, ast; +Cc: davem, netdev, roszenrami, cgroups
On 11/28/2016 12:04 PM, Daniel Mack wrote:
> There's a 'not' missing in one paragraph. Add it.
>
> Signed-off-by: Daniel Mack <daniel@zonque•org>
> Reported-by: Rami Rosen <roszenrami@gmail•com>
> Fixes: 3007098494be ("cgroup: add support for eBPF programs")
Small nit in subject: s/[PATCH]/[PATCH net-next]/
> kernel/bpf/cgroup.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c
> index a0ab43f..b708e6e 100644
> --- a/kernel/bpf/cgroup.c
> +++ b/kernel/bpf/cgroup.c
> @@ -70,9 +70,9 @@ void cgroup_bpf_inherit(struct cgroup *cgrp, struct cgroup *parent)
> * releases the one that is currently attached, if any. @prog is then made
> * the effective program of type @type in that cgroup.
> *
> - * If @prog is %NULL, the currently attached program of type @type is released,
> - * and the effective program of the parent cgroup (if any) is inherited to
> - * @cgrp.
> + * If @prog is not %NULL, the currently attached program of type @type is
> + * released, and the effective program of the parent cgroup (if any) is
> + * inherited to @cgrp.
Both paragraphs for __cgroup_bpf_update() currently say:
[...]
* If @prog is %NULL, this function attaches a new program to the cgroup and
* releases the one that is currently attached, if any. @prog is then made
* the effective program of type @type in that cgroup.
*
* If @prog is %NULL, the currently attached program of type @type is released,
* and the effective program of the parent cgroup (if any) is inherited to
* @cgrp.
[...]
It looks to me that you are 'fixing' the wrong location. First paragraph is
actually missing a "not", which would then also align with what the code does.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-28 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-28 11:04 [PATCH] bpf: cgroup: fix documentation of __cgroup_bpf_update() Daniel Mack
2016-11-28 13:03 ` Daniel Borkmann
[not found] ` <583C2B19.7010506-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2016-11-28 13:07 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox