From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Jiri Benc <jbenc@redhat•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
ramanb@cumulusnetworks•com, stephen@networkplumber•org,
pshelar@ovn•org
Subject: Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down
Date: Mon, 23 Jan 2017 08:31:26 -0800 [thread overview]
Message-ID: <58862FDE.6090008@cumulusnetworks.com> (raw)
In-Reply-To: <20170123095555.0778abb6@griffin>
On 1/23/17, 12:55 AM, Jiri Benc wrote:
> On Fri, 20 Jan 2017 23:43:18 -0800, Roopa Prabhu wrote:
>> This patch skips flushing static fdb entries in
>> ndo_stop, but flushes all fdb entries during vxlan
>> device delete. This is consistent with the bridge
>> driver fdb
> This makes sense but isn't this a uAPI change? Do you know whether
> there are users relying on the current behavior?
>
yeah, i have debated about this also. I am sitting on a stash of such patches
which are borderline bug fixes but been out there long enough that people might care.
I leaned towards making it the default because,
- I am assuming not many people use static entries
- and people will not be very unhappy with this change....because it does not delete something
they had...just retains them.
- Per device flag seems like an overkill here
Also, i think some such changes were done to the bridge driver too after it was out.
next prev parent reply other threads:[~2017-01-23 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 7:43 [PATCH net-next 0/2] vxlan: misc fdb fixes Roopa Prabhu
2017-01-21 7:43 ` [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down Roopa Prabhu
2017-01-23 8:55 ` Jiri Benc
2017-01-23 16:31 ` Roopa Prabhu [this message]
2017-01-23 21:07 ` David Miller
2017-01-24 0:14 ` Roopa Prabhu
2017-01-21 7:43 ` [PATCH net-next 2/2] vxlan: do not age static remote mac entries Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58862FDE.6090008@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jbenc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@ovn$(echo .)org \
--cc=ramanb@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox