public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, ramanb@cumulusnetworks•com,
	stephen@networkplumber•org, jbenc@redhat•com, pshelar@ovn•org
Subject: Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down
Date: Mon, 23 Jan 2017 16:14:38 -0800	[thread overview]
Message-ID: <58869C6E.8090101@cumulusnetworks.com> (raw)
In-Reply-To: <20170123.160741.1558621534864494201.davem@davemloft.net>

On 1/23/17, 1:07 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks•com>
> Date: Fri, 20 Jan 2017 23:43:18 -0800
>
>>  /* Purge the forwarding table */
>> -static void vxlan_flush(struct vxlan_dev *vxlan)
>> +static void vxlan_flush(struct vxlan_dev *vxlan, int do_all)
> Please use 'bool' and true/false for this new argument.
>
> FWIW, I am fine with changing the default behavior in this way.

ack, will fix and post a v2, thanks.

  reply	other threads:[~2017-01-24  0:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21  7:43 [PATCH net-next 0/2] vxlan: misc fdb fixes Roopa Prabhu
2017-01-21  7:43 ` [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down Roopa Prabhu
2017-01-23  8:55   ` Jiri Benc
2017-01-23 16:31     ` Roopa Prabhu
2017-01-23 21:07   ` David Miller
2017-01-24  0:14     ` Roopa Prabhu [this message]
2017-01-21  7:43 ` [PATCH net-next 2/2] vxlan: do not age static remote mac entries Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58869C6E.8090101@cumulusnetworks.com \
    --to=roopa@cumulusnetworks$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=jbenc@redhat$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pshelar@ovn$(echo .)org \
    --cc=ramanb@cumulusnetworks$(echo .)com \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox