From: Daniel Borkmann <daniel@iogearbox•net>
To: naresh.kamboju@linaro•org, shuahkh@osg•samsung.com,
linux-kselftest@vger•kernel.org
Cc: linux-kernel@vger•kernel.org, davem@davemloft•net,
alexei.starovoitov@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is present in the path before insert
Date: Thu, 07 Sep 2017 11:16:52 +0200 [thread overview]
Message-ID: <59B10E84.9090801@iogearbox.net> (raw)
In-Reply-To: <1504772342-21878-1-git-send-email-naresh.kamboju@linaro.org>
On 09/07/2017 10:19 AM, naresh.kamboju@linaro•org wrote:
> From: Naresh Kamboju <naresh.kamboju@linaro•org>
>
> The test script works when kernel source and build module test_bpf.ko
> present on the machine. This patch will check if module is present in
> the path.
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro•org>
Looks good, what changed between v1 and v2? Didn't get the cover
letter in case there was one. ;)
Which tree are you targeting? There are usually a lot of changes
in BPF selftests going the usual route via net and net-next tree
as we often require to put test cases along the BPF patches. Given
the merge window now and given one can regard it as a fix, it's
net tree. I'm also ok if Shuah wants to pick it up this window as
test_kmod.sh hasn't been changed in quite a while, so no merge
conflicts expected.
Anyway, for the patch:
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
Thanks!
> ---
> tools/testing/selftests/bpf/test_kmod.sh | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
> index 6d58cca8e235..a53eb1cb54ef 100755
> --- a/tools/testing/selftests/bpf/test_kmod.sh
> +++ b/tools/testing/selftests/bpf/test_kmod.sh
> @@ -9,9 +9,11 @@ test_run()
>
> echo "[ JIT enabled:$1 hardened:$2 ]"
> dmesg -C
> - insmod $SRC_TREE/lib/test_bpf.ko 2> /dev/null
> - if [ $? -ne 0 ]; then
> - rc=1
> + if [ -f $SRC_TREE/lib/test_bpf.ko ]; then
> + insmod $SRC_TREE/lib/test_bpf.ko 2> /dev/null
> + if [ $? -ne 0 ]; then
> + rc=1
> + fi
> fi
> rmmod test_bpf 2> /dev/null
> dmesg | grep FAIL
>
next parent reply other threads:[~2017-09-07 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1504772342-21878-1-git-send-email-naresh.kamboju@linaro.org>
2017-09-07 9:16 ` Daniel Borkmann [this message]
2017-11-06 15:23 ` [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is present in the path before insert Naresh Kamboju
2017-11-06 16:16 ` Shuah Khan
[not found] ` <1504772342-21878-2-git-send-email-naresh.kamboju@linaro.org>
2017-09-07 9:20 ` [PATCH v2 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device Daniel Borkmann
2017-11-06 15:08 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59B10E84.9090801@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shuahkh@osg$(echo .)samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox