From: Daniel Borkmann <daniel@iogearbox•net>
To: naresh.kamboju@linaro•org, shuahkh@osg•samsung.com,
linux-kselftest@vger•kernel.org
Cc: linux-kernel@vger•kernel.org, davem@davemloft•net,
alexei.starovoitov@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH v2 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device
Date: Thu, 07 Sep 2017 11:20:16 +0200 [thread overview]
Message-ID: <59B10F50.5020109@iogearbox.net> (raw)
In-Reply-To: <1504772342-21878-2-git-send-email-naresh.kamboju@linaro.org>
On 09/07/2017 10:19 AM, naresh.kamboju@linaro•org wrote:
> From: Naresh Kamboju <naresh.kamboju@linaro•org>
>
> on ARM and ARM64 devices kernel source tree is not available so
> insmod "$SRC_TREE/lib/test_bpf.ko" is not working.
>
> on these target devices the test_bpf.ko is installed under
> /lib/modules/`uname -r`/kernel/lib/
> so use modprobe dry run to check for missing test_bpf.ko module and
> insert for testing.
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro•org>
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
One really small nit that could probably be fixed up along the
way when applying:
> ---
> tools/testing/selftests/bpf/test_kmod.sh | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
> index a53eb1cb54ef..eab9a970d742 100755
> --- a/tools/testing/selftests/bpf/test_kmod.sh
> +++ b/tools/testing/selftests/bpf/test_kmod.sh
> @@ -14,6 +14,16 @@ test_run()
> if [ $? -ne 0 ]; then
> rc=1
> fi
> + else
Looks like a whitespace slipped in right before the "else",
so should be removed to only habe the tab indent.
> + # Use modprobe dry run to check for missing test_bpf module
> + if ! /sbin/modprobe -q -n test_bpf; then
> + echo "test_bpf: [SKIP]"
> + elif /sbin/modprobe -q test_bpf; then
> + echo "test_bpf: ok"
> + else
> + echo "test_bpf: [FAIL]"
> + rc=1
> + fi
> fi
> rmmod test_bpf 2> /dev/null
> dmesg | grep FAIL
>
next prev parent reply other threads:[~2017-09-07 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1504772342-21878-1-git-send-email-naresh.kamboju@linaro.org>
2017-09-07 9:16 ` [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is present in the path before insert Daniel Borkmann
2017-11-06 15:23 ` Naresh Kamboju
2017-11-06 16:16 ` Shuah Khan
[not found] ` <1504772342-21878-2-git-send-email-naresh.kamboju@linaro.org>
2017-09-07 9:20 ` Daniel Borkmann [this message]
2017-11-06 15:08 ` [PATCH v2 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59B10F50.5020109@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=naresh.kamboju@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shuahkh@osg$(echo .)samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox