From: Subash Abhinov Kasiviswanathan <subashab@codeaurora•org>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail•com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail•com>,
Steffen Klassert <steffen.klassert@secunet•com>,
Network Development <netdev@vger•kernel.org>,
Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO
Date: Wed, 18 Sep 2019 13:31:26 -0600 [thread overview]
Message-ID: <621219c0a965d6ccc05b80081218ff7e@codeaurora.org> (raw)
In-Reply-To: <20190918165817.GA3431@localhost.localdomain>
On 2019-09-18 10:58, Marcelo Ricardo Leitner wrote:
> On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote:
>> On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert
>> <steffen.klassert@secunet•com> wrote:
>> >
>> > This patchset adds support to do GRO/GSO by chaining packets
>> > of the same flow at the SKB frag_list pointer. This avoids
>> > the overhead to merge payloads into one big packet, and
>> > on the other end, if GSO is needed it avoids the overhead
>> > of splitting the big packet back to the native form.
>> >
>> > Patch 1 Enables UDP GRO by default.
>> >
>> > Patch 2 adds a netdev feature flag to enable listifyed GRO,
>> > this implements one of the configuration options discussed
>> > at netconf 2019.
>> >
>> > Patch 3 adds a netdev software feature set that defaults to off
>> > and assigns the new listifyed GRO feature flag to it.
>> >
>> > Patch 4 adds the core infrastructure to do fraglist GRO/GSO.
>> >
>> > Patch 5 enables UDP to use fraglist GRO/GSO if configured and no
>> > GRO supported socket is found.
>>
>> Very nice feature, Steffen. Aside from questions around performance,
>> my only question is really how this relates to GSO_BY_FRAGS.
>
> They do the exact same thing AFAICT: they GSO according to a
> pre-formatted list of fragments/packets, and not to a specific size
> (such as MSS).
>
>>
>> More specifically, whether we can remove that in favor of using your
>> new skb_segment_list. That would actually be a big first step in
>> simplifying skb_segment back to something manageable.
>
> The main issue (that I know) on obsoleting GSO_BY_FRAGS is that
> dealing with frags instead of frag_list was considered easier to be
> offloaded, if ever attempted. So this would be a step back on that
> aspect. Other than this, it should be doable.
Is there an existing userspace interface for GSO_BY_FRAGS for UDP?
Per my understanding, the current UDP_GSO CMSG option only allows
for a specific GSO_SIZE segmentation.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-09-18 19:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 7:25 [PATCH RFC v3 0/5] Support fraglist GRO/GSO Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 1/5] UDP: enable GRO by default Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 2/5] net: Add NETIF_F_GRO_LIST feature Steffen Klassert
2019-09-18 16:10 ` Willem de Bruijn
2019-09-19 2:04 ` Subash Abhinov Kasiviswanathan
2019-09-19 9:32 ` Steffen Klassert
2019-09-19 9:24 ` Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 3/5] net: Add a netdev software feature set that defaults to off Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 4/5] net: Support GRO/GSO fraglist chaining Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 5/5] udp: Support UDP fraglist GRO/GSO Steffen Klassert
2019-09-18 16:13 ` Willem de Bruijn
2019-09-19 9:33 ` Steffen Klassert
2019-09-18 16:17 ` [PATCH RFC v3 0/5] Support " Willem de Bruijn
2019-09-18 16:58 ` Marcelo Ricardo Leitner
2019-09-18 19:31 ` Subash Abhinov Kasiviswanathan [this message]
2019-09-19 11:01 ` Steffen Klassert
2019-09-19 11:18 ` David Miller
2019-09-19 11:36 ` Steffen Klassert
2019-09-19 12:55 ` Willem de Bruijn
2019-09-19 13:07 ` Marcelo Ricardo Leitner
2019-09-19 13:25 ` Willem de Bruijn
2019-09-19 9:41 ` Steffen Klassert
2019-09-19 13:11 ` Marcelo Ricardo Leitner
2019-09-19 12:37 ` Or Gerlitz
2019-09-19 13:51 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621219c0a965d6ccc05b80081218ff7e@codeaurora.org \
--to=subashab@codeaurora$(echo .)org \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox