From: Subash Abhinov Kasiviswanathan <subashab@codeaurora•org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail•com>
Cc: Steffen Klassert <steffen.klassert@secunet•com>,
Network Development <netdev@vger•kernel.org>,
Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH RFC v3 2/5] net: Add NETIF_F_GRO_LIST feature
Date: Wed, 18 Sep 2019 20:04:18 -0600 [thread overview]
Message-ID: <8bc2e1658e74963d6c3ff297acdcbce6@codeaurora.org> (raw)
In-Reply-To: <CA+FuTSeBmGY4_2X3Ydhf60G=An9g9iikDBQMDji=XptN_jBqiw@mail.gmail.com>
On 2019-09-18 10:10, Willem de Bruijn wrote:
> On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert
> <steffen.klassert@secunet•com> wrote:
>>
>> This adds a new NETIF_F_GRO_LIST feature flag. I will be used
>> to configure listfyed GRO what will be implemented with some
>> followup paches.
>
> This should probably simultaneously introduce SKB_GSO_FRAGLIST as well
> as a BUILD_BUG_ON in net_gso_ok.
>
> Please also in the commit describe the constraints of skbs that have
> this type. If I'm not mistaken, an skb with either gso_size linear
> data or one gso_sized frag, followed by a frag_list of the same. With
> the exception of the last frag_list member, whose mss may be less than
> gso_size. This will help when reasoning about all the types of skbs we
> may see at segmentation, as we recently had to do [1]
>
Would it be preferrable to allow any size skbs for the listification.
Since the original skbs are being restored, single gso_size shoudln't
be a constraint here.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-09-19 2:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 7:25 [PATCH RFC v3 0/5] Support fraglist GRO/GSO Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 1/5] UDP: enable GRO by default Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 2/5] net: Add NETIF_F_GRO_LIST feature Steffen Klassert
2019-09-18 16:10 ` Willem de Bruijn
2019-09-19 2:04 ` Subash Abhinov Kasiviswanathan [this message]
2019-09-19 9:32 ` Steffen Klassert
2019-09-19 9:24 ` Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 3/5] net: Add a netdev software feature set that defaults to off Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 4/5] net: Support GRO/GSO fraglist chaining Steffen Klassert
2019-09-18 7:25 ` [PATCH RFC v3 5/5] udp: Support UDP fraglist GRO/GSO Steffen Klassert
2019-09-18 16:13 ` Willem de Bruijn
2019-09-19 9:33 ` Steffen Klassert
2019-09-18 16:17 ` [PATCH RFC v3 0/5] Support " Willem de Bruijn
2019-09-18 16:58 ` Marcelo Ricardo Leitner
2019-09-18 19:31 ` Subash Abhinov Kasiviswanathan
2019-09-19 11:01 ` Steffen Klassert
2019-09-19 11:18 ` David Miller
2019-09-19 11:36 ` Steffen Klassert
2019-09-19 12:55 ` Willem de Bruijn
2019-09-19 13:07 ` Marcelo Ricardo Leitner
2019-09-19 13:25 ` Willem de Bruijn
2019-09-19 9:41 ` Steffen Klassert
2019-09-19 13:11 ` Marcelo Ricardo Leitner
2019-09-19 12:37 ` Or Gerlitz
2019-09-19 13:51 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc2e1658e74963d6c3ff297acdcbce6@codeaurora.org \
--to=subashab@codeaurora$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox