From: Josua Mayer <josua@solid-run•com>
To: kernel test robot <lkp@intel•com>, netdev@vger•kernel.org
Cc: kbuild-all@lists•01.org, alvaro.karsz@solid-run•com,
Michael Hennerich <michael.hennerich@analog•com>,
Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH v2 2/3] net: phy: adin: add support for clock output
Date: Wed, 27 Apr 2022 10:06:40 +0300 [thread overview]
Message-ID: <651b6fce-cf2a-439f-7454-533bf830a048@solid-run.com> (raw)
In-Reply-To: <202204211324.qgcPMycQ-lkp@intel.com>
\o/
I am going to fix this by using NULL in v3.
Is there any other feedback I should take into account on this patch?
- Josua Mayer
Am 21.04.22 um 09:45 schrieb kernel test robot:
> Hi Josua,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on robh/for-next]
> [also build test WARNING on net/master net-next/master v5.18-rc3 next-20220420]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Josua-Mayer/dt-bindings-net-adin-document-phy-clock-output-properties/20220419-192719
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> config: openrisc-randconfig-s032-20220420 (https://download.01.org/0day-ci/archive/20220421/202204211324.qgcPMycQ-lkp@intel.com/config)
> compiler: or1k-linux-gcc (GCC) 11.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> # https://github.com/intel-lab-lkp/linux/commit/74d856f1c89a6534fd58889f20ad4b481b8191c9
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Josua-Mayer/dt-bindings-net-adin-document-phy-clock-output-properties/20220419-192719
> git checkout 74d856f1c89a6534fd58889f20ad4b481b8191c9
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/phy/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel•com>
>
>
> sparse warnings: (new ones prefixed by >>)
>>> drivers/net/phy/adin.c:448:27: sparse: sparse: Using plain integer as NULL pointer
> vim +448 drivers/net/phy/adin.c
>
> 444
> 445 static int adin_config_clk_out(struct phy_device *phydev)
> 446 {
> 447 struct device *dev = &phydev->mdio.dev;
> > 448 const char *val = 0;
> 449 u8 sel = 0;
> 450
> 451 device_property_read_string(dev, "adi,phy-output-clock", &val);
> 452 if(!val) {
> 453 /* property not present, do not enable GP_CLK pin */
> 454 } else if(strcmp(val, "25mhz-reference") == 0) {
> 455 sel |= ADIN1300_GE_CLK_CFG_25;
> 456 } else if(strcmp(val, "125mhz-free-running") == 0) {
> 457 sel |= ADIN1300_GE_CLK_CFG_FREE_125;
> 458 } else if(strcmp(val, "125mhz-recovered") == 0) {
> 459 sel |= ADIN1300_GE_CLK_CFG_RCVR_125;
> 460 } else if(strcmp(val, "adaptive-free-running") == 0) {
> 461 sel |= ADIN1300_GE_CLK_CFG_HRT_FREE;
> 462 } else if(strcmp(val, "adaptive-recovered") == 0) {
> 463 sel |= ADIN1300_GE_CLK_CFG_HRT_RCVR;
> 464 } else {
> 465 phydev_err(phydev, "invalid adi,phy-output-clock\n");
> 466 return -EINVAL;
> 467 }
> 468
> 469 if(device_property_read_bool(dev, "adi,phy-output-reference-clock"))
> 470 sel |= ADIN1300_GE_CLK_CFG_REF_EN;
> 471
> 472 return phy_modify_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_GE_CLK_CFG_REG,
> 473 ADIN1300_GE_CLK_CFG_MASK, sel);
> 474 }
> 475
>
next prev parent reply other threads:[~2022-04-27 7:06 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 10:46 [PATCH 0/3] adin: add support for 125MHz clk-out Josua Mayer
2022-04-10 10:46 ` [PATCH 1/3] dt: adin: document clk-out property Josua Mayer
2022-04-10 14:21 ` Krzysztof Kozlowski
2022-04-10 18:41 ` Josua Mayer
2022-04-10 19:01 ` Krzysztof Kozlowski
2022-04-11 7:42 ` Josua Mayer
2022-04-11 20:07 ` Jakub Kicinski
2022-04-11 20:59 ` Andrew Lunn
2022-04-11 21:33 ` Jakub Kicinski
2022-04-12 0:29 ` Andrew Lunn
2022-04-10 10:46 ` [PATCH 2/3] net: phy: adin: add support for 125MHz clk-out Josua Mayer
2022-04-10 10:46 ` [PATCH 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer
2022-04-19 10:27 ` [PATCH v2 0/3] adin: add support for clock output Josua Mayer
2022-04-19 10:27 ` [PATCH v2 1/3] dt-bindings: net: adin: document phy clock output properties Josua Mayer
2022-04-21 12:24 ` Andrew Lunn
2022-04-19 10:27 ` [PATCH v2 2/3] net: phy: adin: add support for clock output Josua Mayer
2022-04-21 6:45 ` kernel test robot
2022-04-27 7:06 ` Josua Mayer [this message]
2022-04-19 10:27 ` [PATCH v2 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer
2022-04-21 12:27 ` Andrew Lunn
2022-04-21 13:03 ` Russell King (Oracle)
2022-04-21 13:30 ` Andrew Lunn
2022-04-21 14:20 ` Russell King (Oracle)
2022-04-27 7:15 ` Josua Mayer
2022-05-09 16:01 ` Russell King (Oracle)
2022-04-28 8:28 ` [PATCH v3 0/3] adin: add support for clock output Josua Mayer
2022-04-28 8:28 ` [PATCH v3 1/3] dt-bindings: net: adin: document phy clock output properties Josua Mayer
2022-05-05 15:52 ` Josua Mayer
2022-05-05 20:24 ` Krzysztof Kozlowski
2022-05-08 9:57 ` Josua Mayer
2022-05-09 7:21 ` Krzysztof Kozlowski
2022-05-09 12:36 ` Josua Mayer
2022-04-28 8:28 ` [PATCH v3 2/3] net: phy: adin: add support for clock output Josua Mayer
2022-04-28 12:21 ` Andrew Lunn
2022-04-28 12:52 ` Josua Mayer
2022-04-28 23:34 ` Andrew Lunn
2022-04-28 8:28 ` [PATCH v3 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer
2022-05-05 1:42 ` Shawn Guo
2022-05-09 14:36 ` [PATCH v4 0/3] adin: add support for clock output Josua Mayer
2022-05-09 14:36 ` [PATCH v4 1/3] dt-bindings: net: adin: document phy clock output properties Josua Mayer
2022-05-10 10:22 ` Krzysztof Kozlowski
2022-05-10 20:39 ` Jakub Kicinski
2022-05-11 12:58 ` [PATCH v4 1/3] dt-bindings: net: adin: document phy clock Michael Walle
2022-05-11 16:11 ` Jakub Kicinski
2022-05-11 17:10 ` Michael Walle
2022-05-11 19:42 ` Jakub Kicinski
2022-05-12 21:20 ` Michael Walle
2022-05-12 22:44 ` Jakub Kicinski
2022-05-15 7:16 ` Josua Mayer
2022-05-16 17:43 ` Jakub Kicinski
2022-05-16 19:48 ` Josua Mayer
2022-05-16 22:40 ` Jakub Kicinski
2022-05-17 8:50 ` Josua Mayer
2022-05-09 14:36 ` [PATCH v4 2/3] net: phy: adin: add support for clock output Josua Mayer
2022-05-09 14:36 ` [PATCH v4 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=651b6fce-cf2a-439f-7454-533bf830a048@solid-run.com \
--to=josua@solid-run$(echo .)com \
--cc=alvaro.karsz@solid-run$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=lkp@intel$(echo .)com \
--cc=michael.hennerich@analog$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox