public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run•com>
To: netdev@vger•kernel.org, shawnguo@kernel•org
Cc: alvaro.karsz@solid-run•com, Andrew Lunn <andrew@lunn•ch>,
	Michael Hennerich <michael.hennerich@analog•com>,
	"David S. Miller" <davem@davemloft•net>,
	Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
	Rob Herring <robh+dt@kernel•org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro•org>,
	Alexandru Ardelean <alexandru.ardelean@analog•com>
Subject: Re: [PATCH v3 1/3] dt-bindings: net: adin: document phy clock output properties
Date: Thu, 5 May 2022 18:52:17 +0300	[thread overview]
Message-ID: <d19efad6-16e5-0b7e-de89-97d008afff33@solid-run.com> (raw)
In-Reply-To: <20220428082848.12191-2-josua@solid-run.com>

Hi Shawn,

Thank you for looking at patch 3 in this series, in case you missed it - 
the adi,phy-output-clock property does not yet exist in bindings, I am 
trying to get that one added.

Am 28.04.22 um 11:28 schrieb Josua Mayer:
> The ADIN1300 supports generating certain clocks on its GP_CLK pin, as
> well as providing the reference clock on CLK25_REF.
>
> Add DT properties to configure both pins.
>
> Signed-off-by: Josua Mayer <josua@solid-run•com>
> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
> ---
> V1 -> V2: changed clkout property to enum
> V1 -> V2: added property for CLK25_REF pin
>
>   .../devicetree/bindings/net/adi,adin.yaml       | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml
> index 1129f2b58e98..3e0c6304f190 100644
> --- a/Documentation/devicetree/bindings/net/adi,adin.yaml
> +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml
> @@ -36,6 +36,23 @@ properties:
>       enum: [ 4, 8, 12, 16, 20, 24 ]
>       default: 8
>   
> +  adi,phy-output-clock:
> +    description: Select clock output on GP_CLK pin. Three clocks are available:
> +      A 25MHz reference, a free-running 125MHz and a recovered 125MHz.
> +      The phy can also automatically switch between the reference and the
> +      respective 125MHz clocks based on its internal state.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum:
> +    - 25mhz-reference
> +    - 125mhz-free-running
> +    - 125mhz-recovered
> +    - adaptive-free-running
> +    - adaptive-recovered
> +
> +  adi,phy-output-reference-clock:
> +    description: Enable 25MHz reference clock output on CLK25_REF pin.
> +    $ref: /schemas/types.yaml#/definitions/flag
> +
>   unevaluatedProperties: false
>   
>   examples:
- Josua Mayer

  reply	other threads:[~2022-05-05 15:52 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-10 10:46 [PATCH 0/3] adin: add support for 125MHz clk-out Josua Mayer
2022-04-10 10:46 ` [PATCH 1/3] dt: adin: document clk-out property Josua Mayer
2022-04-10 14:21   ` Krzysztof Kozlowski
2022-04-10 18:41     ` Josua Mayer
2022-04-10 19:01       ` Krzysztof Kozlowski
2022-04-11  7:42         ` Josua Mayer
2022-04-11 20:07           ` Jakub Kicinski
2022-04-11 20:59             ` Andrew Lunn
2022-04-11 21:33               ` Jakub Kicinski
2022-04-12  0:29                 ` Andrew Lunn
2022-04-10 10:46 ` [PATCH 2/3] net: phy: adin: add support for 125MHz clk-out Josua Mayer
2022-04-10 10:46 ` [PATCH 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer
2022-04-19 10:27 ` [PATCH v2 0/3] adin: add support for clock output Josua Mayer
2022-04-19 10:27   ` [PATCH v2 1/3] dt-bindings: net: adin: document phy clock output properties Josua Mayer
2022-04-21 12:24     ` Andrew Lunn
2022-04-19 10:27   ` [PATCH v2 2/3] net: phy: adin: add support for clock output Josua Mayer
2022-04-21  6:45     ` kernel test robot
2022-04-27  7:06       ` Josua Mayer
2022-04-19 10:27   ` [PATCH v2 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer
2022-04-21 12:27     ` Andrew Lunn
2022-04-21 13:03       ` Russell King (Oracle)
2022-04-21 13:30         ` Andrew Lunn
2022-04-21 14:20           ` Russell King (Oracle)
2022-04-27  7:15             ` Josua Mayer
2022-05-09 16:01               ` Russell King (Oracle)
2022-04-28  8:28   ` [PATCH v3 0/3] adin: add support for clock output Josua Mayer
2022-04-28  8:28     ` [PATCH v3 1/3] dt-bindings: net: adin: document phy clock output properties Josua Mayer
2022-05-05 15:52       ` Josua Mayer [this message]
2022-05-05 20:24       ` Krzysztof Kozlowski
2022-05-08  9:57         ` Josua Mayer
2022-05-09  7:21           ` Krzysztof Kozlowski
2022-05-09 12:36         ` Josua Mayer
2022-04-28  8:28     ` [PATCH v3 2/3] net: phy: adin: add support for clock output Josua Mayer
2022-04-28 12:21       ` Andrew Lunn
2022-04-28 12:52         ` Josua Mayer
2022-04-28 23:34           ` Andrew Lunn
2022-04-28  8:28     ` [PATCH v3 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer
2022-05-05  1:42       ` Shawn Guo
2022-05-09 14:36     ` [PATCH v4 0/3] adin: add support for clock output Josua Mayer
2022-05-09 14:36       ` [PATCH v4 1/3] dt-bindings: net: adin: document phy clock output properties Josua Mayer
2022-05-10 10:22         ` Krzysztof Kozlowski
2022-05-10 20:39         ` Jakub Kicinski
2022-05-11 12:58           ` [PATCH v4 1/3] dt-bindings: net: adin: document phy clock Michael Walle
2022-05-11 16:11             ` Jakub Kicinski
2022-05-11 17:10               ` Michael Walle
2022-05-11 19:42                 ` Jakub Kicinski
2022-05-12 21:20                   ` Michael Walle
2022-05-12 22:44                     ` Jakub Kicinski
2022-05-15  7:16                       ` Josua Mayer
2022-05-16 17:43                         ` Jakub Kicinski
2022-05-16 19:48                           ` Josua Mayer
2022-05-16 22:40                             ` Jakub Kicinski
2022-05-17  8:50                               ` Josua Mayer
2022-05-09 14:36       ` [PATCH v4 2/3] net: phy: adin: add support for clock output Josua Mayer
2022-05-09 14:36       ` [PATCH v4 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d19efad6-16e5-0b7e-de89-97d008afff33@solid-run.com \
    --to=josua@solid-run$(echo .)com \
    --cc=alexandru.ardelean@analog$(echo .)com \
    --cc=alvaro.karsz@solid-run$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
    --cc=kuba@kernel$(echo .)org \
    --cc=michael.hennerich@analog$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=robh+dt@kernel$(echo .)org \
    --cc=shawnguo@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox