From: Roman Mashak <mrv@mojatatu•com>
To: Girish Moodalbail <girish.moodalbail@oracle•com>
Cc: <stephen@networkplumber•org>, <netdev@vger•kernel.org>
Subject: Re: [PATCH iproute2 v2 1/1] vxlan: Add support for modifying vxlan device attributes
Date: Sun, 07 May 2017 10:40:29 -0400 [thread overview]
Message-ID: <85shkgd92a.fsf@mojatatu.com> (raw)
In-Reply-To: <1494095863-21916-2-git-send-email-girish.moodalbail@oracle.com> (Girish Moodalbail's message of "Sat, 6 May 2017 11:37:43 -0700")
Girish Moodalbail <girish.moodalbail@oracle•com> writes:
[...]
> ip/iplink_vxlan.c | 251 +++++++++++++++++++++++++++++++-----------------------
> 1 file changed, 143 insertions(+), 108 deletions(-)
>
> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> index b4ebb13..2bd619d 100644
> --- a/ip/iplink_vxlan.c
> +++ b/ip/iplink_vxlan.c
> @@ -21,6 +21,8 @@
> #include "utils.h"
> #include "ip_common.h"
>
> +#define VXLAN_ATTRSET(attrs, type) (((attrs) & (1L << (type))) != 0)
I think you can drop '!= 0' part in the macro.
[...]
>
> +static void check_duparg(__u64 *attrs, int type, const char *key,
> + const char *argv)
> +{
> + if (!VXLAN_ATTRSET(*attrs, type)) {
> + *attrs |= (1L << type);
> + return;
> + }
> + duparg2(key, argv);
> +}
[...]
next prev parent reply other threads:[~2017-05-07 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 18:37 [PATCH iproute2 v2 0/1] vxlan: support for modifying vxlan device Girish Moodalbail
2017-05-06 18:37 ` [PATCH iproute2 v2 1/1] vxlan: Add support for modifying vxlan device attributes Girish Moodalbail
2017-05-07 14:40 ` Roman Mashak [this message]
2017-05-10 7:31 ` Girish Moodalbail
2017-05-11 18:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85shkgd92a.fsf@mojatatu.com \
--to=mrv@mojatatu$(echo .)com \
--cc=girish.moodalbail@oracle$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox