From: Kurt Kanzenbach <kurt@linutronix•de>
To: Joe Damato <jdamato@fastly•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Gerhard Engleder <gerhard@engleder-embedded•com>,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org
Subject: Re: [PATCH iwl-next v2 2/4] igb: Link queues to NAPI instances
Date: Mon, 10 Mar 2025 17:10:53 +0100 [thread overview]
Message-ID: <8734fkq31u.fsf@kurt.kurt.home> (raw)
In-Reply-To: <Z86kBp2m-L-usV0V@LQ3V64L9R2>
[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]
On Mon Mar 10 2025, Joe Damato wrote:
> On Fri, Mar 07, 2025 at 02:03:44PM -0800, Tony Nguyen wrote:
>> On 2/17/2025 3:31 AM, Kurt Kanzenbach wrote:
>>
>> ...
>>
>> > diff --git a/drivers/net/ethernet/intel/igb/igb_xsk.c b/drivers/net/ethernet/intel/igb/igb_xsk.c
>> > index 157d43787fa0b55a74714f69e9e7903b695fcf0a..a5ad090dfe94b6afc8194fe39d28cdd51c7067b0 100644
>> > --- a/drivers/net/ethernet/intel/igb/igb_xsk.c
>> > +++ b/drivers/net/ethernet/intel/igb/igb_xsk.c
>> > @@ -45,6 +45,7 @@ static void igb_txrx_ring_disable(struct igb_adapter *adapter, u16 qid)
>> > synchronize_net();
>> > /* Rx/Tx share the same napi context. */
>> > + igb_set_queue_napi(adapter, qid, NULL);
>> > napi_disable(&rx_ring->q_vector->napi);
>> > igb_clean_tx_ring(tx_ring);
>> > @@ -78,6 +79,7 @@ static void igb_txrx_ring_enable(struct igb_adapter *adapter, u16 qid)
>> > /* Rx/Tx share the same napi context. */
>> > napi_enable(&rx_ring->q_vector->napi);
>> > + igb_set_queue_napi(adapter, qid, &rx_ring->q_vector->napi);
>> > }
>> > struct xsk_buff_pool *igb_xsk_pool(struct igb_adapter *adapter,
>>
>> I believe Joe's fix/changes [1] need to be done here as well?
>>
>> Thanks,
>> Tony
>>
>> [1] https://lore.kernel.org/intel-wired-lan/9ddf6293-6cb0-47ea-a0e7-cad7d33c2535@intel.com/T/#m863614df1fb3d1980ad09016b1c9ef4e2f0b074e
>
> Yes, the code above should be dropped. Sorry I missed that during
> review - thanks for catching that, Tony.
>
> Kurt: when you respin this to fix what Tony mentioned, can you also
> run the test mentioned above?
Hi Tony & Joe,
Hm. I did run the test and it succeeded. I'll take a look at it next
week when I'm back in the office.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2025-03-10 16:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 11:31 [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up Kurt Kanzenbach
2025-02-17 11:31 ` [PATCH iwl-next v2 1/4] igb: Link IRQs to NAPI instances Kurt Kanzenbach
2025-02-28 9:00 ` [Intel-wired-lan] " Rinitha, SX
2025-02-17 11:31 ` [PATCH iwl-next v2 2/4] igb: Link queues " Kurt Kanzenbach
2025-02-18 21:13 ` Joe Damato
2025-02-19 7:41 ` Kurt Kanzenbach
2025-02-19 17:55 ` Joe Damato
2025-02-20 7:43 ` Kurt Kanzenbach
2025-02-28 9:00 ` [Intel-wired-lan] " Rinitha, SX
2025-03-07 22:03 ` Tony Nguyen
2025-03-10 8:34 ` Joe Damato
2025-03-10 16:10 ` Kurt Kanzenbach [this message]
2025-02-17 11:31 ` [PATCH iwl-next v2 3/4] igb: Add support for persistent NAPI config Kurt Kanzenbach
2025-02-18 21:15 ` Joe Damato
2025-02-21 13:51 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-02-28 9:00 ` Rinitha, SX
2025-02-17 11:31 ` [PATCH iwl-next v2 4/4] igb: Get rid of spurious interrupts Kurt Kanzenbach
2025-02-21 12:44 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-03-07 10:26 ` Kumari, Sweta
2025-02-18 21:18 ` [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up Joe Damato
2025-02-18 22:00 ` Joe Damato
2025-02-19 14:03 ` Kurt Kanzenbach
2025-02-19 17:51 ` Joe Damato
2025-02-20 7:44 ` Kurt Kanzenbach
2025-02-19 7:39 ` Kurt Kanzenbach
2025-02-20 2:06 ` Jakub Kicinski
2025-02-21 20:53 ` Joe Damato
2025-02-21 22:26 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734fkq31u.fsf@kurt.kurt.home \
--to=kurt@linutronix$(echo .)de \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gerhard@engleder-embedded$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jdamato@fastly$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox