From: Vinicius Costa Gomes <vinicius.gomes@intel•com>
To: David Laight <David.Laight@ACULAB•COM>,
'Ivan Khoronzhuk' <ivan.khoronzhuk@linaro•org>
Cc: "netdev\@vger.kernel.org" <netdev@vger•kernel.org>,
"intel-wired-lan\@lists.osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"jhs\@mojatatu.com" <jhs@mojatatu•com>,
"xiyou.wangcong\@gmail.com" <xiyou.wangcong@gmail•com>,
"jiri\@resnulli.us" <jiri@resnulli•us>,
"andre.guedes\@intel.com" <andre.guedes@intel•com>,
"ivan.briano\@intel.com" <ivan.briano@intel•com>,
"jesus.sanchez-palencia\@intel.com"
<jesus.sanchez-palencia@intel•com>,
"boon.leong.ong\@intel.com" <boon.leong.ong@intel•com>,
"richardcochran\@gmail.com" <richardcochran@gmail•com>,
"henrik\@austad.us" <henrik@austad•us>,
"levipearson\@gmail.com" <levipearson@gmail•com>,
"rodney.cummings\@ni.com" <rodney.cummings@ni•com>
Subject: RE: [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc
Date: Mon, 16 Oct 2017 15:13:12 -0700 [thread overview]
Message-ID: <87376in3lz.fsf@intel.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD00979BC@AcuExch.aculab.com>
Hi David,
David Laight <David.Laight@ACULAB•COM> writes:
[...]
>> > index 099bf5528fed..41e349df4bf4 100644
>> > --- a/include/uapi/linux/pkt_sched.h
>> > +++ b/include/uapi/linux/pkt_sched.h
>> > @@ -871,4 +871,22 @@ struct tc_pie_xstats {
>> > __u32 maxq; /* maximum queue size */
>> > __u32 ecn_mark; /* packets marked with ecn*/
>> > };
>> > +
>> > +/* CBS */
>> > +struct tc_cbs_qopt {
>> > + __u8 offload;
>
> You probably don't want unnamed padding in a uapi structure.
Yeah, this needs to be fixed.
>
>> > + __s32 hicredit;
>> > + __s32 locredit;
>> > + __s32 idleslope;
>> > + __s32 sendslope;
>> > +};
>> > +
>> > +enum {
>> > + TCA_CBS_UNSPEC,
>> > + TCA_CBS_PARMS,
>> > + __TCA_CBS_MAX,
>> > +};
>> > +
>> > +#define TCA_CBS_MAX (__TCA_CBS_MAX - 1)
>
> Why not:
> TCA_CBS_PARMS,
> TCA_CBS_NEXT,
> TCA_CBS_MAX = TCA_CBS_NEXT - 1,
The way it is proposed, at least is consistent with the rest of the
file. So, if you don't have any stronger reasons, I'd like to keep it
this way.
>
> ...
> David
Cheers,
next prev parent reply other threads:[~2017-10-16 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 0:39 [next-queue PATCH v7 0/6] TSN: Add qdisc based config interface for CBS Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 1/6] net/sched: Check for null dev_queue on create flow Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 2/6] net/sched: Change behavior of mq select_queue() Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 3/6] net/sched: Add select_queue() class_ops for mqprio Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc Vinicius Costa Gomes
2017-10-13 2:42 ` Eric Dumazet
2017-10-13 17:12 ` Vinicius Costa Gomes
2017-10-13 19:59 ` Ivan Khoronzhuk
2017-10-13 22:54 ` Vinicius Costa Gomes
2017-10-16 9:14 ` David Laight
2017-10-16 22:13 ` Vinicius Costa Gomes [this message]
2017-10-13 0:40 ` [next-queue PATCH v7 5/6] net/sched: Add support for HW offloading for CBS Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 6/6] igb: Add support for CBS offload Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87376in3lz.fsf@intel.com \
--to=vinicius.gomes@intel$(echo .)com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=andre.guedes@intel$(echo .)com \
--cc=boon.leong.ong@intel$(echo .)com \
--cc=henrik@austad$(echo .)us \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ivan.briano@intel$(echo .)com \
--cc=ivan.khoronzhuk@linaro$(echo .)org \
--cc=jesus.sanchez-palencia@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=levipearson@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=rodney.cummings@ni$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox