From: Vinicius Costa Gomes <vinicius.gomes@intel•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us,
andre.guedes@intel•com, ivan.briano@intel•com,
jesus.sanchez-palencia@intel•com, boon.leong.ong@intel•com,
richardcochran@gmail•com, henrik@austad•us,
levipearson@gmail•com, rodney.cummings@ni•com
Subject: Re: [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc
Date: Fri, 13 Oct 2017 10:12:18 -0700 [thread overview]
Message-ID: <87efq7m0p9.fsf@intel.com> (raw)
In-Reply-To: <1507862553.31614.53.camel@edumazet-glaptop3.roam.corp.google.com>
Hi,
Eric Dumazet <eric.dumazet@gmail•com> writes:
[...]
>
> Your mixing of s64 and u64 is disturbing.
>
> do_div() handles u64, not s64.
>
> div64_s64() might be needed in place of do_div()
I wasn't very comfortable about the signal juggling either. Didn't know
about div64_s64(), looks much better. Will fix, thanks.
Cheers,
next prev parent reply other threads:[~2017-10-13 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 0:39 [next-queue PATCH v7 0/6] TSN: Add qdisc based config interface for CBS Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 1/6] net/sched: Check for null dev_queue on create flow Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 2/6] net/sched: Change behavior of mq select_queue() Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 3/6] net/sched: Add select_queue() class_ops for mqprio Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc Vinicius Costa Gomes
2017-10-13 2:42 ` Eric Dumazet
2017-10-13 17:12 ` Vinicius Costa Gomes [this message]
2017-10-13 19:59 ` Ivan Khoronzhuk
2017-10-13 22:54 ` Vinicius Costa Gomes
2017-10-16 9:14 ` David Laight
2017-10-16 22:13 ` Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 5/6] net/sched: Add support for HW offloading for CBS Vinicius Costa Gomes
2017-10-13 0:40 ` [next-queue PATCH v7 6/6] igb: Add support for CBS offload Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efq7m0p9.fsf@intel.com \
--to=vinicius.gomes@intel$(echo .)com \
--cc=andre.guedes@intel$(echo .)com \
--cc=boon.leong.ong@intel$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=henrik@austad$(echo .)us \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ivan.briano@intel$(echo .)com \
--cc=jesus.sanchez-palencia@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=levipearson@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=rodney.cummings@ni$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox