From: Aaron Conole <aconole@bytheb•org>
To: Andrey Vagin <avagin@gmail•com>
Cc: netdev@vger•kernel.org, Andrey Vagin <avagin@openvz•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>
Subject: Re: [PATCH] net/unix: fix logic about sk_peek_offset
Date: Sun, 04 Oct 2015 08:50:02 -0400 [thread overview]
Message-ID: <8737xq3iit.fsf@bytheb.org> (raw)
In-Reply-To: <1443733536-992-1-git-send-email-avagin@gmail.com> (Andrey Vagin's message of "Fri, 2 Oct 2015 00:05:36 +0300")
Andrey Vagin <avagin@gmail•com> writes:
> From: Andrey Vagin <avagin@openvz•org>
>
> Now send with MSG_PEEK can return data from multiple SKBs.
>
> Unfortunately we take into account the peek offset for each skb,
> that is wrong. We need to apply the peek offset only once.
>
> In addition, the peek offset should be used only if MSG_PEEK is set.
>
> Cc: "David S. Miller" <davem@davemloft•net> (maintainer:NETWORKING
> Cc: Eric Dumazet <edumazet@google•com> (commit_signer:1/14=7%)
> Cc: Aaron Conole <aconole@bytheb•org>
> Fixes: 9f389e35674f ("af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag")
> Signed-off-by: Andrey Vagin <avagin@openvz•org>
> ---
Tested-by: Aaron Conole <aconole@bytheb•org>
Thanks again!
next prev parent reply other threads:[~2015-10-04 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 21:05 [PATCH] net/unix: fix logic about sk_peek_offset Andrey Vagin
2015-10-02 9:04 ` Andrey Vagin
2015-10-02 12:17 ` Aaron Conole
2015-10-03 19:48 ` Andrey Vagin
2015-10-04 12:50 ` Aaron Conole [this message]
2015-10-05 13:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737xq3iit.fsf@bytheb.org \
--to=aconole@bytheb$(echo .)org \
--cc=avagin@gmail$(echo .)com \
--cc=avagin@openvz$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox