From: Aaron Conole <aconole@bytheb•org>
To: Andrey Vagin <avagin@openvz•org>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>
Subject: Re: [PATCH] net/unix: fix logic about sk_peek_offset
Date: Fri, 02 Oct 2015 08:17:39 -0400 [thread overview]
Message-ID: <87r3ldmplo.fsf@bytheb.org> (raw)
In-Reply-To: <CANaxB-zvEL6WRNk2Ho7uJUVO8L=t_Nutp9Zxz=Do+Xp1JibHKw@mail.gmail.com> (Andrey Vagin's message of "Fri, 2 Oct 2015 12:04:39 +0300")
Andrey Vagin <avagin@openvz•org> writes:
> 2015-10-02 0:05 GMT+03:00 Andrey Vagin <avagin@gmail•com>:
>> From: Andrey Vagin <avagin@openvz•org>
>>
>> Now send with MSG_PEEK can return data from multiple SKBs.
>>
>> Unfortunately we take into account the peek offset for each skb,
>> that is wrong. We need to apply the peek offset only once.
>>
>> In addition, the peek offset should be used only if MSG_PEEK is set.
<<snip>>
Agreed here, the behavior is off in the peek offset case.
I was unable to apply your patch, for some reason, but will manually
try to apply it and test.
Thanks very much!
next prev parent reply other threads:[~2015-10-02 12:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 21:05 [PATCH] net/unix: fix logic about sk_peek_offset Andrey Vagin
2015-10-02 9:04 ` Andrey Vagin
2015-10-02 12:17 ` Aaron Conole [this message]
2015-10-03 19:48 ` Andrey Vagin
2015-10-04 12:50 ` Aaron Conole
2015-10-05 13:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3ldmplo.fsf@bytheb.org \
--to=aconole@bytheb$(echo .)org \
--cc=avagin@openvz$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox