From: ebiederm@xmission•com (Eric W. Biederman)
To: David Miller <davem@davemloft•net>
Cc: amwang@redhat•com, netdev@vger•kernel.org
Subject: Re: [Patch net-next] sctp: fix a compile error in sctp.h
Date: Wed, 15 Aug 2012 12:53:23 -0700 [thread overview]
Message-ID: <874no4c4p8.fsf@xmission.com> (raw)
In-Reply-To: <20120815.034501.1424538455974526416.davem@davemloft.net> (David Miller's message of "Wed, 15 Aug 2012 03:45:01 -0700 (PDT)")
David Miller <davem@davemloft•net> writes:
> From: Cong Wang <amwang@redhat•com>
> Date: Wed, 15 Aug 2012 18:18:11 +0800
>
>> I got the following compile error:
>>
>> In file included from include/net/sctp/checksum.h:46:0,
>> from net/ipv4/netfilter/nf_nat_proto_sctp.c:14:
>> include/net/sctp/sctp.h: In function ‘sctp_dbg_objcnt_init’:
>> include/net/sctp/sctp.h:370:88: error: parameter name omitted
>> include/net/sctp/sctp.h: In function ‘sctp_dbg_objcnt_exit’:
>> include/net/sctp/sctp.h:371:88: error: parameter name omitted
>>
>> which is caused by
>>
>> commit 13d782f6b4fbbaf9d0380a9947deb45a9de46ae7
>> Author: Eric W. Biederman <ebiederm@xmission•com>
>> Date: Mon Aug 6 08:45:15 2012 +0000
>>
>> sctp: Make the proc files per network namespace.
>>
>> This patch could fix it.
>>
>> Cc: David S. Miller <davem@davemloft•net>
>> Cc: "Eric W. Biederman" <ebiederm@xmission•com>
>> Signed-off-by: Cong Wang <amwang@redhat•com>
>
> Applied thanks.
>
> I appended the SCTP debug objcnt procfs netns conversions by hand
> since Eric didn't handle it in his commit.
>
> Eric, please turn all relevant options both on and off when testing
> the build of your patches. Thanks.
Grr. My apologies. It looks like that one slipped by me this time :(
Eric
prev parent reply other threads:[~2012-08-15 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 10:18 [Patch net-next] sctp: fix a compile error in sctp.h Cong Wang
2012-08-15 10:45 ` David Miller
2012-08-15 19:53 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874no4c4p8.fsf@xmission.com \
--to=ebiederm@xmission$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox