From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: "Arend Van Spriel"
<arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"Franky Lin" <franky.lin-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"Hante Meuleman"
<hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"Pieter-Paul Giesberts"
<pieter-paul.giesberts-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"Franky Lin" <frankyl-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"linux-wireless@vger•kernel.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"Network Development"
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"Linux Kernel Mailing List"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public•gmane.org>
Subject: Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring
Date: Tue, 27 Sep 2016 15:08:20 +0300 [thread overview]
Message-ID: <8760phy28b.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACna6rxDb_KMwGTFKu1Mf9azmk_PLO0aLR3foRtkqyywa1DNVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> ("Rafał Miłecki"'s message of "Tue, 27 Sep 2016 13:58:56 +0200")
Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> writes:
>>>>> Kalle: this isn't important enough for 4.8 as it's too late for that.
>>>>>
>>>>> I'd like to get it for 4.9 however, as this fixes bug that could lead
>>>>> to WARNING on every add_key/del_key call. We was struggling with these
>>>>> WARNINGs for some time and this fixes one of two problems causing them.
>>>
>>> Ok, I'll queue this for 4.9.
>>>
>>>> Please mark it for stable as well.
>>>
>>> I can add that. Any ideas how old releases stable releases should this
>>> go to?
>>
>> I was analyzing this.
>> 1) This patch uses brcmf_get_ifp which is available in 4.4+ only.
>> 2) It applies cleanly to 4.5+ only due to 32f90caa7debd ("brcmfmac:
>> Increase nr of supported flowrings.")
>> 3) 4.4 would also require applying to the patch without broadcom/ subdir
>>
>> That said I suggest 4.5+. Any objections?
>
> Let me see if patchwork with pick Cc tag as it does for others.
>
> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public•gmane.org # 4.5+
An excellent idea but no luck:
Signed-off-by: Rafa? Mi?ecki <rafal-g1n6cQUeyibVItvQsEIGlw@public•gmane.org>
Acked-by: Arend van Spriel <arend-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>
I'll add this to my patchwork wishlist though, I think it would be a
really useful feature to have.
(The question marks are because of my buggy copy paste, ignore those)
--
Kalle Valo
next prev parent reply other threads:[~2016-09-27 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:14 [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring Rafał Miłecki
2016-09-27 10:05 ` Arend Van Spriel
2016-09-27 11:27 ` Kalle Valo
2016-09-27 11:33 ` Arend Van Spriel
2016-09-27 11:44 ` Rafał Miłecki
[not found] ` <CACna6rwUR_GidhEFNTN+8mGQRpBdUzeM1-0NY65k6-McX7xGVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-27 11:58 ` Rafał Miłecki
[not found] ` <CACna6rxDb_KMwGTFKu1Mf9azmk_PLO0aLR3foRtkqyywa1DNVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-27 12:04 ` Arend Van Spriel
[not found] ` <41e5f45f-1956-8c9d-49d4-cd73e2c5c7c0-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-09-27 12:07 ` Rafał Miłecki
2016-09-27 12:08 ` Kalle Valo [this message]
[not found] ` <20160927091428.19223-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-27 12:11 ` [PATCH V2 " Rafał Miłecki
2016-09-27 15:48 ` [V2, " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760phy28b.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public$(echo .)gmane.org \
--cc=arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=franky.lin-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=frankyl-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=pieter-paul.giesberts-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=rafal-g1n6cQUeyibVItvQsEIGlw@public$(echo .)gmane.org \
--cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox