From: Kalle Valo <kvalo@codeaurora•org>
To: Arend Van Spriel <arend.vanspriel@broadcom•com>
Cc: "Rafał Miłecki" <zajec5@gmail•com>,
"Franky Lin" <franky.lin@broadcom•com>,
"Hante Meuleman" <hante.meuleman@broadcom•com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom•com>,
"Franky Lin" <frankyl@broadcom•com>,
linux-wireless@vger•kernel.org,
brcm80211-dev-list.pdl@broadcom•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, "Rafał Miłecki" <rafal@milecki•pl>
Subject: Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring
Date: Tue, 27 Sep 2016 14:27:42 +0300 [thread overview]
Message-ID: <87inthy441.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <86fd0b60-0f73-484b-1788-3ec740672232@broadcom.com> (Arend Van Spriel's message of "Tue, 27 Sep 2016 12:05:09 +0200")
Arend Van Spriel <arend.vanspriel@broadcom•com> writes:
> On 27-9-2016 11:14, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki•pl>
>>
>> Flowrings contain skbs waiting for transmission that were passed to us
>> by netif. It means we checked every one of them looking for 802.1x
>> Ethernet type. When deleting flowring we have to use freeing function
>> that will check for 802.1x type as well.
>>
>> Freeing skbs without a proper check was leading to counter not being
>> properly decreased. This was triggering a WARNING every time
>> brcmf_netdev_wait_pend8021x was called.
>
> Acked-by: Arend van Spriel <arend@broadcom•com>
>> Signed-off-by: Rafał Miłecki <rafal@milecki•pl>
>> ---
>> Kalle: this isn't important enough for 4.8 as it's too late for that.
>>
>> I'd like to get it for 4.9 however, as this fixes bug that could lead
>> to WARNING on every add_key/del_key call. We was struggling with these
>> WARNINGs for some time and this fixes one of two problems causing them.
Ok, I'll queue this for 4.9.
> Please mark it for stable as well.
I can add that. Any ideas how old releases stable releases should this
go to?
--
Kalle Valo
next prev parent reply other threads:[~2016-09-27 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:14 [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring Rafał Miłecki
2016-09-27 10:05 ` Arend Van Spriel
2016-09-27 11:27 ` Kalle Valo [this message]
2016-09-27 11:33 ` Arend Van Spriel
2016-09-27 11:44 ` Rafał Miłecki
[not found] ` <CACna6rwUR_GidhEFNTN+8mGQRpBdUzeM1-0NY65k6-McX7xGVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-27 11:58 ` Rafał Miłecki
[not found] ` <CACna6rxDb_KMwGTFKu1Mf9azmk_PLO0aLR3foRtkqyywa1DNVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-27 12:04 ` Arend Van Spriel
[not found] ` <41e5f45f-1956-8c9d-49d4-cd73e2c5c7c0-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-09-27 12:07 ` Rafał Miłecki
2016-09-27 12:08 ` Kalle Valo
[not found] ` <20160927091428.19223-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-27 12:11 ` [PATCH V2 " Rafał Miłecki
2016-09-27 15:48 ` [V2, " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inthy441.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora$(echo .)org \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=brcm80211-dev-list.pdl@broadcom$(echo .)com \
--cc=franky.lin@broadcom$(echo .)com \
--cc=frankyl@broadcom$(echo .)com \
--cc=hante.meuleman@broadcom$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pieter-paul.giesberts@broadcom$(echo .)com \
--cc=rafal@milecki$(echo .)pl \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox