From: "Bjørn Mork" <bjorn@mork•no>
To: netdev@vger•kernel.org
Subject: Re: [PATCH] net: cdc_ether.c: Add SE J105i to device whitelist
Date: Mon, 04 Jan 2010 15:50:22 +0100 [thread overview]
Message-ID: <878wcdx6tt.fsf@nemi.mork.no> (raw)
In-Reply-To: 1261604906.609.106.camel@localhost.localdomain
Marcel Holtmann <marcel@holtmann•org> writes:
>> This patch adds the Sony Ericsson J105i (Naite)
>> mobile phone to the cdc_ether device whitelist,
>> enabling access to the modem.
>>
>> I would think more SE models of this generation
>> (2009Q3) with builtin HSDPA modules also needs
>> to be added to this list.
>
> I do prefer if we NOT use the mbm_info details for this since they are
> clearly for mobile broadband cards with FLAG_WWAN.
Assuming that these devices can be configured just like the WWAN cards
by sending commands to the associated ACM* or WDM* interfaces, why would
you treat them differently? Because they've got a keyboard and a
display?
> Since this is a phone where the setup of the connection is done via the
> phone. And you just treat this as an Ethernet device and run DHCP, then
> please create a se_info or similar with FLAG_ETHER.
Why would anyone want to setup the connection via the phone? That seems
unnecessary cumbersome. I'd prefer such devices to be auto-configured
just like any other WWAN device.
Bjørn
next prev parent reply other threads:[~2010-01-04 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 20:56 [PATCH] net: cdc_ether.c: Add SE J105i to device whitelist Thomas Loo
2009-12-23 21:48 ` Marcel Holtmann
2010-01-04 14:50 ` Bjørn Mork [this message]
2010-01-04 21:10 ` Marcel Holtmann
2010-01-05 7:34 ` Bjørn Mork
2010-01-05 11:31 ` Marcel Holtmann
2010-01-05 12:46 ` Bjørn Mork
2010-01-05 20:52 ` Marcel Holtmann
2010-01-07 6:38 ` Dan Williams
2010-01-07 8:50 ` Bjørn Mork
2010-01-07 16:21 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wcdx6tt.fsf@nemi.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox