From: Petr Machata <petrm@mellanox•com>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Jiri Pirko <jiri@resnulli•us>,
Linux Kernel Network Developers <netdev@vger•kernel.org>,
Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <eric.dumazet@gmail•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Jiri Pirko <jiri@mellanox•com>,
Ido Schimmel <idosch@mellanox•com>
Subject: Re: [RFC PATCH net-next 0/3] TC: Introduce qevents
Date: Tue, 02 Jun 2020 00:37:25 +0200 [thread overview]
Message-ID: <87d06itntm.fsf@mellanox.com> (raw)
In-Reply-To: <CAM_iQpXTWK+-_42CsVsL==XOSZO1tGeSDCz=BkgAaRsJvZL6TQ@mail.gmail.com>
Cong Wang <xiyou.wangcong@gmail•com> writes:
> On Mon, Jun 1, 2020 at 6:40 AM Jiri Pirko <jiri@resnulli•us> wrote:
>> The first command just says "early drop position should be processed by
>> block 10"
>>
>> The second command just adds a filter to the block 10.
> This is exactly why it looks odd to me, because it _reads_ like
> 'tc qdisc' creates the block to hold tc filters... I think tc filters should
> create whatever placeholder for themselves.
Look at clsact. It creates blocks in exactly the same way.
> I know in memory block (or chain or filters) are stored in qdisc, but
> it is still different to me who initiates the creation.
The block binding mechanics are not new. The patch just reuses them. If
you are unhappy about how this is currently done, I too would see merit
in creating a block explicitly, like with chains. But it has nothing to
do with this patchset, which would just naturally pick up whatever this
new mechanic is.
next prev parent reply other threads:[~2020-06-01 22:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:10 [RFC PATCH net-next 0/3] TC: Introduce qevents Petr Machata
2020-05-26 17:10 ` [RFC PATCH net-next 1/3] net: sched: Introduce helpers for qevent blocks Petr Machata
2020-05-26 17:10 ` [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and change callbacks Petr Machata
2020-05-26 18:32 ` Jakub Kicinski
2020-05-27 15:23 ` Petr Machata
2020-05-26 17:10 ` [RFC PATCH net-next 3/3] net: sched: sch_red: Add qevents "early" and "mark" Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 1/4] uapi: pkt_sched: Add two new RED attributes Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 2/4] tc: Add helpers to support qevent parsing Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 3/4] man: tc: Describe qevents Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 4/4] tc: q_red: Add support for qevents "mark" and "early" Petr Machata
2020-05-27 4:09 ` [RFC PATCH net-next 0/3] TC: Introduce qevents Cong Wang
2020-05-27 9:56 ` Petr Machata
2020-05-28 4:00 ` Cong Wang
2020-05-28 9:48 ` Petr Machata
2020-05-30 4:48 ` Cong Wang
2020-05-30 8:55 ` Petr Machata
2020-06-01 20:01 ` Cong Wang
2020-06-01 13:35 ` Jiri Pirko
2020-06-01 13:40 ` Jiri Pirko
2020-06-01 19:50 ` Cong Wang
2020-06-01 22:37 ` Petr Machata [this message]
2020-06-02 6:05 ` Jiri Pirko
2020-06-03 7:05 ` Cong Wang
2020-06-03 10:08 ` Petr Machata
2020-05-27 15:19 ` Vladimir Oltean
2020-05-27 16:25 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d06itntm.fsf@mellanox.com \
--to=petrm@mellanox$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox