From: Kalle Valo <kvalo@qca•qualcomm.com>
To: Johan Hovold <johan@kernel•org>
Cc: ath9k-devel <ath9k-devel@qca•qualcomm.com>,
Daniel Drake <dsd@gentoo•org>,
Ulrich Kunitz <kune@deine-taler•de>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-usb@vger•kernel.org" <linux-usb@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe
Date: Mon, 3 Apr 2017 13:21:08 +0000 [thread overview]
Message-ID: <87fuhpmxto.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170403131616.GA3119@localhost> (Johan Hovold's message of "Mon, 3 Apr 2017 15:16:16 +0200")
Johan Hovold <johan@kernel•org> writes:
> On Mon, Apr 03, 2017 at 01:02:28PM +0000, Kalle Valo wrote:
>> Kalle Valo <kvalo@codeaurora•org> writes:
>>
>> > Johan Hovold <johan@kernel•org> writes:
>> >
>> >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote:
>> >>> Make sure to check the number of endpoints to avoid dereferencing a
>> >>> NULL-pointer or accessing memory beyond the endpoint array should a
>> >>> malicious device lack the expected endpoints.
>> >>>
>> >>> Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices")
>> >>> Cc: Sujith Manoharan <Sujith.Manoharan@atheros•com>
>> >>> Signed-off-by: Johan Hovold <johan@kernel•org>
>> >>
>> >> Is this one still in your queue, Kalle?
>> >
>> > Yes, I'm just lacking behing:
>> >
>> > https://patchwork.kernel.org/patch/9620723/
>>
>> Meant "lagging" of course. Mondays..
>>
>> >> As I mentioned earlier, I should have added a
>> >>
>> >> Cc: stable <stable@vger•kernel.org> # 2.6.39
>> >>
>> >> but left it out as I mistakingly thought the net recommendations to do
>> >> so applied also to wireless.
>> >
>> > Ok, I'll add that.
>>
>> But is 2.6.39 really correct? Shouldn't it be 2.6.39+ so that it means
>> all versions since 2.6.39?
>
> Either way is fine, the stable maintainers apply them to all later
> versions.
>
> I notice now that adding a plus sign is more common, but it's still a
> 1:2 ratio judging from quick grep, while the stable-kernel-rules.rst
> actually uses a minus sign...
Heh, quite confusing :) I added the plus sign already to the patch in my
pending branch so unless you object I'll keep it.
--
Kalle Valo
next prev parent reply other threads:[~2017-04-03 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 12:44 [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Johan Hovold
2017-03-13 12:44 ` [PATCH 2/2] wireless: zd1211rw: " Johan Hovold
[not found] ` <20170313124421.28587-2-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-22 9:04 ` [2/2] " Kalle Valo
2017-03-22 12:45 ` Johan Hovold
2017-03-22 13:02 ` Kalle Valo
2017-03-22 13:24 ` Johan Hovold
2017-04-03 8:42 ` [PATCH 1/2] wireless: ath9k_htc: " Johan Hovold
2017-04-03 9:34 ` Kalle Valo
2017-04-03 13:02 ` Kalle Valo
[not found] ` <87k271myos.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2017-04-03 13:16 ` Johan Hovold
2017-04-03 13:21 ` Kalle Valo [this message]
2017-04-03 13:26 ` Johan Hovold
2017-04-05 7:35 ` [1/2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuhpmxto.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca$(echo .)qualcomm.com \
--cc=ath9k-devel@qca$(echo .)qualcomm.com \
--cc=dsd@gentoo$(echo .)org \
--cc=johan@kernel$(echo .)org \
--cc=kune@deine-taler$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox