From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>
To: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>
Cc: QCA ath9k Development
<ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public•gmane.org>,
Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public•gmane.org>,
Ulrich Kunitz <kune-hUSrv6EASfkEnNRfnnE9gw@public•gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [2/2] zd1211rw: fix NULL-deref at probe
Date: Wed, 22 Mar 2017 15:02:12 +0200 [thread overview]
Message-ID: <87r31p31nv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170322124548.GC10130@localhost> (Johan Hovold's message of "Wed, 22 Mar 2017 13:45:48 +0100")
Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org> writes:
> On Wed, Mar 22, 2017 at 09:04:15AM +0000, Kalle Valo wrote:
>> Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org> wrote:
>> > Make sure to check the number of endpoints to avoid dereferencing a
>> > NULL-pointer or accessing memory beyond the endpoint array should a
>> > malicious device lack the expected endpoints.
>> >
>> > Fixes: a1030e92c150 ("[PATCH] zd1211rw: Convert installer CDROM
>> > device into WLAN device")
>> > Cc: Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public•gmane.org>
>> > Signed-off-by: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>
>>
>> Patch applied to wireless-drivers-next.git, thanks.
>>
>> ca260ece6a57 zd1211rw: fix NULL-deref at probe
>
> What about patch 1/2 which fixes the same bug (literally copied from the
> zd1211rw driver)?
I will apply that to my separate ath.git tree, just didn't get to your
patch yet.
> And as these fixes should be backported to stable (I left out the tag
> for networking drivers)
Actually for wireless drivers you should add the stable tag.
> why only apply to -next?
I didn't see that the fix was important enough for 4.11.
--
Kalle Valo
next prev parent reply other threads:[~2017-03-22 13:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 12:44 [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe Johan Hovold
2017-03-13 12:44 ` [PATCH 2/2] wireless: zd1211rw: " Johan Hovold
[not found] ` <20170313124421.28587-2-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-22 9:04 ` [2/2] " Kalle Valo
2017-03-22 12:45 ` Johan Hovold
2017-03-22 13:02 ` Kalle Valo [this message]
2017-03-22 13:24 ` Johan Hovold
2017-04-03 8:42 ` [PATCH 1/2] wireless: ath9k_htc: " Johan Hovold
2017-04-03 9:34 ` Kalle Valo
2017-04-03 13:02 ` Kalle Valo
[not found] ` <87k271myos.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2017-04-03 13:16 ` Johan Hovold
2017-04-03 13:21 ` Kalle Valo
2017-04-03 13:26 ` Johan Hovold
2017-04-05 7:35 ` [1/2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r31p31nv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public$(echo .)gmane.org \
--cc=ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public$(echo .)gmane.org \
--cc=dsd-aBrp7R+bbdUdnm+yROfE0A@public$(echo .)gmane.org \
--cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
--cc=kune-hUSrv6EASfkEnNRfnnE9gw@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox