From: ebiederm@xmission•com (Eric W. Biederman)
To: Rami Rosen <ramirose@gmail•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, shemminger@vyatta•com
Subject: Re: [RFC PATCH v2 net-next 1/2] ppp: remove NETIF_F_NETNS_LOCAL from ppp device features.
Date: Mon, 07 Jan 2013 01:16:45 -0800 [thread overview]
Message-ID: <87hamt73pe.fsf@xmission.com> (raw)
In-Reply-To: <1357543176-15352-2-git-send-email-ramirose@gmail.com> (Rami Rosen's message of "Mon, 7 Jan 2013 09:19:35 +0200")
Rami Rosen <ramirose@gmail•com> writes:
> There is no need for NETIF_F_NETNS_LOCAL for ppp device; this patch
> removes it.
At least pppoe_rcv_core assumes that the ppp socket and the network
devices are all in the same network namespace. So it looks like
NETIF_F_NETNS_LOCAL is needed.
Eric
> Signed-off-by: Rami Rosen <ramirose@gmail•com>
> ---
> drivers/net/ppp/ppp_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
> index 0b2706a..89b6fc5 100644
> --- a/drivers/net/ppp/ppp_generic.c
> +++ b/drivers/net/ppp/ppp_generic.c
> @@ -1073,7 +1073,6 @@ static void ppp_setup(struct net_device *dev)
> dev->tx_queue_len = 3;
> dev->type = ARPHRD_PPP;
> dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST;
> - dev->features |= NETIF_F_NETNS_LOCAL;
> dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
> }
next prev parent reply other threads:[~2013-01-07 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 7:19 [RFC PATCH v2 net-next 0/2] Remove NETIF_F_NETNS_LOCAL from software devices Rami Rosen
2013-01-07 7:19 ` [RFC PATCH v2 net-next 1/2] ppp: remove NETIF_F_NETNS_LOCAL from ppp device features Rami Rosen
2013-01-07 9:16 ` Eric W. Biederman [this message]
2013-01-07 7:19 ` [RFC PATCH v2 net-next 2/2] bridge: remove NETIF_F_NETNS_LOCAL from bridge " Rami Rosen
2013-01-07 9:20 ` Eric W. Biederman
2013-01-07 9:25 ` [RFC PATCH v2 net-next 0/2] Remove NETIF_F_NETNS_LOCAL from software devices Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hamt73pe.fsf@xmission.com \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ramirose@gmail$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox