From: Andi Kleen <andi@firstfloor•org>
To: Eric Cooper <ecc@cmu•edu>
Cc: linux-kernel@vger•kernel.org, linux-doc@vger•kernel.org,
Richard Purdie <rpurdie@rpsys•net>,
Randy Dunlap <rdunlap@xenotime•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH v2] add netdev led trigger
Date: Mon, 29 Nov 2010 11:15:51 +0100 [thread overview]
Message-ID: <87ipzgl9k8.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1290998056-8310-1-git-send-email-ecc@cmu.edu> (Eric Cooper's message of "Sun, 28 Nov 2010 21:34:16 -0500")
Eric Cooper <ecc@cmu•edu> writes:
> Add a netdev LED trigger for all Blinkenlights lovers...
> Originally taken from https://dev.openwrt.org/ticket/2776
> Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko•org>
> and for 2.6.36 by Eric Cooper <ecc@cmu•edu>
You should really send this to netdev too.
Some comments:
The timer seems power unfriendly -- it will always tick even if nothing
happens.
Using the device name as an identifier is not reliable, they may
not be unique.
rwlocks are deprecated.
your store code has a off by one I think, it's possible to put
not 0 terminated data in the string.
-Andi
--
ak@linux•intel.com -- Speaking for myself only.
next parent reply other threads:[~2010-11-29 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1290998056-8310-1-git-send-email-ecc@cmu.edu>
2010-11-29 10:15 ` Andi Kleen [this message]
2010-12-01 0:03 ` [PATCH v2] add netdev led trigger Eric Cooper
2010-12-01 14:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipzgl9k8.fsf@basil.nowhere.org \
--to=andi@firstfloor$(echo .)org \
--cc=ecc@cmu$(echo .)edu \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=rpurdie@rpsys$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox