From: "Bjørn Mork" <bjorn@mork•no>
To: Oliver Neukum <oneukum@suse•com>
Cc: netdev@vger•kernel.org
Subject: Re: [RFC]RNDIS filter issue
Date: Thu, 18 May 2017 15:02:30 +0200 [thread overview]
Message-ID: <87lgpuco7t.fsf@miraculix.mork.no> (raw)
In-Reply-To: <1495111085.6672.7.camel@suse.com> (Oliver Neukum's message of "Thu, 18 May 2017 14:38:05 +0200")
Oliver Neukum <oneukum@suse•com> writes:
> @@ -472,7 +489,6 @@ static void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb)
>
> if (urb->actual_length < sizeof(*event))
> return;
> -
> event = urb->transfer_buffer;
>
> if (event->bNotificationType != USB_CDC_NOTIFY_NETWORK_CONNECTION) {
Spurious whitespace.
And building gives:
/usr/local/src/git/linux/drivers/net/usb/cdc_ether.c:325:5: warning: symbol 'usbnet_ether_cdc_bind' was not declared. Should it be static?
and maybe it should? There is no use for it in any other module, yet.
Or you could declare it in usbnet.h, I guess. Your choice.
Looks good to me if those two minor issues are fixed. But do note that
I currently don't have any way to test this on real hardware...
Bjørn
prev parent reply other threads:[~2017-05-18 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 12:38 [RFC]RNDIS filter issue Oliver Neukum
2017-05-18 13:02 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgpuco7t.fsf@miraculix.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oneukum@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox