public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
To: Florian Fainelli <f.fainelli@gmail•com>, netdev@vger•kernel.org
Cc: davem@davemlof•net, andrew@lunn•ch,
	Florian Fainelli <f.fainelli@gmail•com>
Subject: Re: [PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus
Date: Tue, 07 Jun 2016 10:46:35 -0400	[thread overview]
Message-ID: <87oa7dxdis.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <1465254895-11152-6-git-send-email-f.fainelli@gmail.com>

Hi Florian,

Florian Fainelli <f.fainelli@gmail•com> writes:

>  static int bcm_sf2_sw_setup(struct dsa_switch *ds)
>  {
>  	const char *reg_names[BCM_SF2_REGS_NUM] = BCM_SF2_REGS_NAME;
> @@ -972,6 +1099,12 @@ static int bcm_sf2_sw_setup(struct dsa_switch *ds)
>  		goto out_unmap;
>  	}
>  
> +	ret = bcm_sf2_mdio_register(ds);
> +	if (ret) {
> +		pr_err("failed to register MDIO bus\n");
> +		goto out_unmap;
> +	}
> +
>  	/* Disable all interrupts and request them */
>  	bcm_sf2_intr_disable(priv);

Hum reviewing that again, I see that if one of the 2 subsequent calls to
request_irq fails, you end up with an unregistered MDIO bus.

We have the same issue in the mv88e6xxx legacy probe code if dsa.c fails
to allocate the dsa_switch structure. I'm moving the MDIO register code
to the setup function like you are doing here (good idea!) to fix that.

Thanks,

        Vivien

next prev parent reply	other threads:[~2016-06-07 14:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 23:14 [PATCH net-next v2 0/5] net: dsa: misc improvements Florian Fainelli
2016-06-06 23:14 ` [PATCH net-next v2 1/5] net: dsa: Provide unique DSA slave MII bus names Florian Fainelli
2016-06-06 23:14 ` [PATCH net-next v2 2/5] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask Florian Fainelli
2016-06-07  0:22   ` Andrew Lunn
2016-06-07 13:05     ` Andrew Lunn
2016-06-06 23:14 ` [PATCH net-next v2 3/5] net: dsa: Add initialization helper for CPU port ethtool_ops Florian Fainelli
2016-06-07 13:05   ` Vivien Didelot
2016-06-06 23:14 ` [PATCH net-next v2 4/5] net: dsa: Initialize CPU port ethtool ops per tree Florian Fainelli
2016-06-07  0:34   ` Andrew Lunn
2016-06-06 23:14 ` [PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus Florian Fainelli
2016-06-07  0:39   ` Andrew Lunn
2016-06-07 13:23   ` Vivien Didelot
2016-06-07 14:46   ` Vivien Didelot [this message]
2016-06-07 16:48     ` Vivien Didelot
2016-06-07 17:00       ` Andrew Lunn
2016-06-07 17:33         ` Vivien Didelot
2016-06-07 18:44           ` Andrew Lunn
2016-06-07 19:11             ` Vivien Didelot
2016-06-07 19:29               ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa7dxdis.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=davem@davemlof$(echo .)net \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox