From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail•com>,
Jamal Hadi Salim <jhs@mojatatu•com>
Cc: Eric Dumazet <edumazet@google•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Willem de Bruijn <willemb@google•com>,
Soheil Hassas Yeganeh <soheil@google•com>,
Neal Cardwell <ncardwell@google•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
netdev@vger•kernel.org, eric.dumazet@gmail•com
Subject: Re: [PATCH v2 net-next 0/5] net_sched: sch_fq: round of improvements
Date: Thu, 21 Sep 2023 11:33:48 +0200 [thread overview]
Message-ID: <87pm2blvk3.fsf@toke.dk> (raw)
In-Reply-To: <CAF=yD-LZmJ-a0kO8UtKaj+NTwYaRFQfZkDVHTthz4gNYJfCN4w@mail.gmail.com>
Willem de Bruijn <willemdebruijn.kernel@gmail•com> writes:
> On Wed, Sep 20, 2023 at 7:22 PM Jamal Hadi Salim <jhs@mojatatu•com> wrote:
>>
>> On Wed, Sep 20, 2023 at 4:17 PM Eric Dumazet <edumazet@google•com> wrote:
>> >
>> > For FQ tenth anniversary, it was time for making it faster.
>> >
>> > The FQ part (as in Fair Queue) is rather expensive, because
>> > we have to classify packets and store them in a per-flow structure,
>> > and add this per-flow structure in a hash table. Then the RR lists
>> > also add cache line misses.
>> >
>> > Most fq qdisc are almost idle. Trying to share NIC bandwidth has
>> > no benefits, thus the qdisc could behave like a FIFO.
>> >
>> > This series brings a 5 % throughput increase in intensive
>> > tcp_rr workload, and 13 % increase for (unpaced) UDP packets.
>> >
>> > v2: removed an extra label (build bot).
>> > Fix an accidental increase of stat_internal_packets counter
>> > in fast path.
>> > Added "constify qdisc_priv()" patch to allow fq_fastpath_check()
>> > first parameter to be const.
>> > typo on 'eligible' (Willem)
>>
>> For the patchset:
>> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu•com>
>
> Reviewed-by: Willem de Bruijn <willemb@google•com>
Might as well join the party - nice set of improvements! :)
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat•com>
next prev parent reply other threads:[~2023-09-21 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 20:17 [PATCH v2 net-next 0/5] net_sched: sch_fq: round of improvements Eric Dumazet
2023-09-20 20:17 ` [PATCH v2 net-next 1/5] net_sched: constify qdisc_priv() Eric Dumazet
2023-09-20 20:45 ` Jamal Hadi Salim
2023-09-20 21:32 ` Eric Dumazet
2023-09-20 22:56 ` Jamal Hadi Salim
2023-09-20 20:17 ` [PATCH v2 net-next 2/5] net_sched: sch_fq: struct sched_data reorg Eric Dumazet
2023-09-20 20:17 ` [PATCH v2 net-next 3/5] net_sched: sch_fq: change how @inactive is tracked Eric Dumazet
2023-09-20 20:17 ` [PATCH v2 net-next 4/5] net_sched: sch_fq: add fast path for mostly idle qdisc Eric Dumazet
2023-09-20 20:17 ` [PATCH v2 net-next 5/5] net_sched: sch_fq: always garbage collect Eric Dumazet
2023-09-20 23:22 ` [PATCH v2 net-next 0/5] net_sched: sch_fq: round of improvements Jamal Hadi Salim
2023-09-21 0:16 ` Willem de Bruijn
2023-09-21 9:33 ` Toke Høiland-Jørgensen [this message]
2023-10-01 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm2blvk3.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=soheil@google$(echo .)com \
--cc=willemb@google$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox