From: Jakub Sitnicki <jakub@cloudflare•com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>,
Willem de Bruijn <willemb@google•com>,
kernel-team@cloudflare•com
Subject: Re: [PATCH net 0/2] Lift UDP_SEGMENT restriction for egress via device w/o csum offload
Date: Mon, 24 Jun 2024 13:29:28 +0200 [thread overview]
Message-ID: <87r0cmwpd3.fsf@cloudflare.com> (raw)
In-Reply-To: <6677da5b3c52e_334d34294dd@willemb.c.googlers.com.notmuch> (Willem de Bruijn's message of "Sun, 23 Jun 2024 04:18:35 -0400")
On Sun, Jun 23, 2024 at 04:18 AM -04, Willem de Bruijn wrote:
> Jakub Sitnicki wrote:
>> This is a follow-up to an earlier question [1] if we can make UDP GSO work with
>> any egress device, even those with no checksum offload capability. That's the
>> default setup for TUN/TAP.
>>
>> I leave it to the maintainers to decide if it qualifies as a fix. We plan to
>> backport it to our v6.6 either way, hence the submission to -net.
>>
>> [1] https://lore.kernel.org/netdev/87jzqsld6q.fsf@cloudflare.com/
>
> Agreed with the change to allow UDP_SEGMENT to work regardless of
> device capabilities.
Thanks for the stamp.
> In my opinion this is a new feature with sufficient risk of unintended
> side effects to be net-next material.
OK, I will resubmit for net-next.
> Maybe worth recording in patch 1 the reason for the original check:
> that UDP_SEGMENT with software checksumming in the GSO stack may be
> a regression vs copy_and_checksum in the send syscall.
Will expand the description.
prev parent reply other threads:[~2024-06-24 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 16:14 [PATCH net 0/2] Lift UDP_SEGMENT restriction for egress via device w/o csum offload Jakub Sitnicki
2024-06-22 16:14 ` [PATCH net 1/2] udp: Allow GSO transmit from devices with no checksum offload Jakub Sitnicki
2024-06-22 16:14 ` [PATCH net 2/2] selftests/net: Add test coverage for UDP GSO software fallback Jakub Sitnicki
2024-06-23 2:27 ` Jakub Kicinski
2024-06-24 10:20 ` Jakub Sitnicki
2024-06-23 8:18 ` [PATCH net 0/2] Lift UDP_SEGMENT restriction for egress via device w/o csum offload Willem de Bruijn
2024-06-24 11:29 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0cmwpd3.fsf@cloudflare.com \
--to=jakub@cloudflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kernel-team@cloudflare$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=willemb@google$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox