From: Jakub Sitnicki <jakub@cloudflare•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Willem de Bruijn <willemb@google•com>,
kernel-team@cloudflare•com
Subject: Re: [PATCH net 2/2] selftests/net: Add test coverage for UDP GSO software fallback
Date: Mon, 24 Jun 2024 12:20:53 +0200 [thread overview]
Message-ID: <87v81ywsje.fsf@cloudflare.com> (raw)
In-Reply-To: <20240622192722.689abc7d@kernel.org> (Jakub Kicinski's message of "Sat, 22 Jun 2024 19:27:22 -0700")
On Sat, Jun 22, 2024 at 07:27 PM -07, Jakub Kicinski wrote:
> On Sat, 22 Jun 2024 18:14:44 +0200 Jakub Sitnicki wrote:
>> + ip link add name sink type dummy mtu 1500
>
> Looks like this doesn't make CI happy:
>
> https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/651680/59-udpgso-sh/stdout
>
> I'm guessing "mtu 1500" needs to go before "type dummy"?
> iproute2 hands over arguments after type to type specific handler.
"ip link" got stricter, I see. Been testing against an old one :/
# ip -V
ip utility, iproute2-6.1.0, libbpf 1.2.2
Will rearrange. Thanks for the heads-up.
next prev parent reply other threads:[~2024-06-24 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 16:14 [PATCH net 0/2] Lift UDP_SEGMENT restriction for egress via device w/o csum offload Jakub Sitnicki
2024-06-22 16:14 ` [PATCH net 1/2] udp: Allow GSO transmit from devices with no checksum offload Jakub Sitnicki
2024-06-22 16:14 ` [PATCH net 2/2] selftests/net: Add test coverage for UDP GSO software fallback Jakub Sitnicki
2024-06-23 2:27 ` Jakub Kicinski
2024-06-24 10:20 ` Jakub Sitnicki [this message]
2024-06-23 8:18 ` [PATCH net 0/2] Lift UDP_SEGMENT restriction for egress via device w/o csum offload Willem de Bruijn
2024-06-24 11:29 ` Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v81ywsje.fsf@cloudflare.com \
--to=jakub@cloudflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kernel-team@cloudflare$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox