From: Vlad Buslov <vlad@buslov•dev>
To: Jamal Hadi Salim <jhs@mojatatu•com>
Cc: David Ahern <dsahern@gmail•com>,
netdev@vger•kernel.org, stephen@networkplumber•org,
davem@davemloft•net, kuba@kernel•org, xiyou.wangcong@gmail•com,
jiri@resnulli•us
Subject: Re: [PATCH iproute2-next] tc: implement support for action terse dump
Date: Fri, 06 Nov 2020 21:16:45 +0200 [thread overview]
Message-ID: <87y2je9tya.fsf@buslov.dev> (raw)
In-Reply-To: <178bdf87-8513-625f-1b2e-79ad435bcdf3@mojatatu.com>
On Tue 03 Nov 2020 at 23:59, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
> On 2020-11-03 10:07 a.m., Vlad Buslov wrote:
>>
>> On Tue 03 Nov 2020 at 03:48, David Ahern <dsahern@gmail•com> wrote:
>>> On 10/31/20 2:25 PM, Vlad Buslov wrote:
>>>> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
>>>> index 5ad84e663d01..b486f52900f0 100644
>>>> --- a/include/uapi/linux/rtnetlink.h
>>>> +++ b/include/uapi/linux/rtnetlink.h
>>>> @@ -768,8 +768,12 @@ enum {
>>>> * actions in a dump. All dump responses will contain the number of actions
>>>> * being dumped stored in for user app's consumption in TCA_ROOT_COUNT
>>>> *
>>>> + * TCA_FLAG_TERSE_DUMP user->kernel to request terse (brief) dump that only
>>>> + * includes essential action info (kind, index, etc.)
>>>> + *
>>>> */
>>>> #define TCA_FLAG_LARGE_DUMP_ON (1 << 0)
>>>> +#define TCA_FLAG_TERSE_DUMP (1 << 1)
>>>>
>>>
>>> there is an existing TCA_DUMP_FLAGS_TERSE. How does this differ and if
>>> it really is needed please make it different enough and documented to
>>> avoid confusion.
>>
>> TCA_FLAG_TERSE_DUMP is a bit in TCA_ROOT_FLAGS tlv which is basically
>> "action flags". TCA_DUMP_FLAGS_TERSE is a bit in TCA_DUMP_FLAGS tlv
>> which is dedicated flags attribute for filter dump. We can't just reuse
>> existing filter dump constant because its value "1" is already taken by
>> TCA_FLAG_LARGE_DUMP_ON. This might look confusing, but what do you
>> suggest? Those are two unrelated tlv's. I can rename the constant name
>> to TCA_FLAG_ACTION_TERSE_DUMP to signify that the flag is action
>> specific, but that would make the naming inconsistent with existing
>> TCA_FLAG_LARGE_DUMP_ON.
>>
>
> Its unfortunate that the TCA_ prefix ended being used for both filters
> and actions. Since we only have a couple of flags maybe it is not too
> late to have a prefix TCAA_ ? For existing flags something like a
> #define TCAA_FLAG_LARGE_DUMP_ON TCA_FLAG_LARGE_DUMP_ON
> in the uapi header will help. Of course that would be a separate
> patch which will require conversion code in both the kernel and user
> space.
I can send a followup patch, assuming David is satisfied with proposed
change.
>
> FWIW, the patch is good for what i tested. So even if you do send an
> update with a name change please add:
>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu•com>
>
> cheers,
> jamal
next prev parent reply other threads:[~2020-11-06 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 20:16 [PATCH net-next] net: sched: implement action-specific terse dump Vlad Buslov
2020-10-31 20:25 ` [PATCH iproute2-next] tc: implement support for action " Vlad Buslov
2020-11-03 1:48 ` David Ahern
2020-11-03 15:07 ` Vlad Buslov
2020-11-03 21:59 ` Jamal Hadi Salim
2020-11-06 19:16 ` Vlad Buslov [this message]
2020-11-06 20:25 ` David Ahern
2020-11-06 20:36 ` Jakub Kicinski
2020-11-02 12:26 ` [PATCH net-next] net: sched: implement action-specific " Jamal Hadi Salim
2020-11-02 20:00 ` Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2je9tya.fsf@buslov.dev \
--to=vlad@buslov$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox