From: Vlad Buslov <vlad@buslov•dev>
To: Jamal Hadi Salim <jhs@mojatatu•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, kuba@kernel•org,
xiyou.wangcong@gmail•com, jiri@resnulli•us
Subject: Re: [PATCH net-next] net: sched: implement action-specific terse dump
Date: Mon, 02 Nov 2020 22:00:18 +0200 [thread overview]
Message-ID: <87zh3z5y25.fsf@buslov.dev> (raw)
In-Reply-To: <96c51cbb-1a72-d89d-5746-2930786f8afb@mojatatu.com>
On Mon 02 Nov 2020 at 14:26, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
> Thanks Vlad. Ive run the basic test and it looks good.
> One thing i discovered while testing is that if the
> cookie is set, we also want it in the dump. Your earlier
> comment that it only costs if it was set is on point.
>
> So please remove that check below:
Okay. Will send V2 shortly.
>
>
>> + if (cookie && !from_act) {
>> + if (nla_put(skb, TCA_ACT_COOKIE, cookie->len, cookie->data)) {
>> + rcu_read_unlock();
>> + goto nla_put_failure;
>> + }
>
>
> cheers,
> jamal
prev parent reply other threads:[~2020-11-02 20:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 20:16 [PATCH net-next] net: sched: implement action-specific terse dump Vlad Buslov
2020-10-31 20:25 ` [PATCH iproute2-next] tc: implement support for action " Vlad Buslov
2020-11-03 1:48 ` David Ahern
2020-11-03 15:07 ` Vlad Buslov
2020-11-03 21:59 ` Jamal Hadi Salim
2020-11-06 19:16 ` Vlad Buslov
2020-11-06 20:25 ` David Ahern
2020-11-06 20:36 ` Jakub Kicinski
2020-11-02 12:26 ` [PATCH net-next] net: sched: implement action-specific " Jamal Hadi Salim
2020-11-02 20:00 ` Vlad Buslov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh3z5y25.fsf@buslov.dev \
--to=vlad@buslov$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox