From: Petr Machata <petrm@mellanox•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Jiri Pirko <jiri@mellanox•com>,
Ido Schimmel <idosch@mellanox•com>,
"davem@davemloft•net" <davem@davemloft•net>,
Tariq Toukan <tariqt@mellanox•com>,
"jakub.kicinski@netronome•com" <jakub.kicinski@netronome•com>,
"stephen@networkplumber•org" <stephen@networkplumber•org>
Subject: Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages
Date: Mon, 18 Mar 2019 13:15:41 +0000 [thread overview]
Message-ID: <87zhpsgw7j.fsf@mellanox.com> (raw)
In-Reply-To: <20190316022658.GC29548@lunn.ch>
Andrew Lunn <andrew@lunn•ch> writes:
>> +enum rtnl_link_down_reason_major {
>> + RTNL_LDR_OTHER,
>
> Does 'other' make any sense? Seem better to just not report anything
> at all, or add a comment that more reasons should be added at the end
> to reflect whatever the hardware or software can determine.
You still have the minor code to give you some information.
>> + RTNL_LDR_NO_CABLE,
>> + RTNL_LDR_UNSUPPORTED_CABLE,
>> + RTNL_LDR_AUTONEG_FAILURE,
>> + RTNL_LDR_NO_LINK_PARTNER,
>> + RTNL_LDR_LINK_TRAINING_FAILURE,
>> + RTNL_LDR_LOGICAL_MISMATCH,
>> + RTNL_LDR_REMOTE_FAULT,
>> + RTNL_LDR_BAD_SIGNAL_INTEGRITY,
>> + RTNL_LDR_CALIBRATION_FAILURE,
>> + RTNL_LDR_POWER_BUDGET_EXCEEDED,
>> +};
>
> What about SFP cage empty?, i.e. no SFP, SFP+ module in the cage? An
No cable? Maybe the name needs to change...
> SFP can also report LOS. That does not appear to be any of the above.
> Or that the core SFP code has been unable to read the EEPROM? We have
My assumption was that cable with unreadable EEPROM is simply a bad
cable. Does the admin actually care which particular part of the cable
is at fault?
> people reporting this problem at the moment. We also have that the
> SERDES has not yet obtained sync to its peer, which you know from
> phylink_mac_change. That probably means the peer is using a different
> bit rate.
We can add this.
> I think it would be good if you handle the general case errors which
> phylib and phylink can report, as well as the proprietary cases your
> driver can report. We don't want this to be a Mellanox only API.
Sure, I'll take a look at that. I didn't need to deal with PHY so far,
so I need to figure out what's what.
next prev parent reply other threads:[~2019-03-18 13:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 17:56 [RFC PATCH net-next 0/3] RTNL: Add link-down reason reporting Petr Machata
2019-03-15 17:56 ` [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages Petr Machata
2019-03-16 2:26 ` Jakub Kicinski
2019-03-17 0:24 ` Michal Kubecek
2019-03-18 12:34 ` Petr Machata
2019-03-18 12:43 ` Michal Kubecek
2019-03-18 13:12 ` Andrew Lunn
2019-03-16 2:26 ` Andrew Lunn
2019-03-18 13:15 ` Petr Machata [this message]
2019-03-18 13:33 ` Andrew Lunn
2019-03-18 13:47 ` Petr Machata
2019-03-18 14:02 ` Andrew Lunn
2019-03-18 15:52 ` Stephen Hemminger
2019-03-19 10:18 ` Petr Machata
2019-03-19 11:56 ` Michal Kubecek
2019-03-19 15:42 ` Stephen Hemminger
2019-03-19 15:57 ` Petr Machata
2019-03-17 22:38 ` Roopa Prabhu
2019-03-18 0:03 ` Andrew Lunn
2019-03-28 17:59 ` Petr Machata
2019-03-28 19:51 ` Andrew Lunn
2019-04-23 13:41 ` Jiri Pirko
2019-03-18 12:15 ` Petr Machata
2019-03-15 17:56 ` [RFC PATCH net-next 2/3] mlxsw: reg: Add Port Diagnostics Database Register Petr Machata
2019-03-15 17:56 ` [RFC PATCH net-next 3/3] mlxsw: spectrum: Add rtnl_link_ops Petr Machata
2019-03-16 2:06 ` [RFC PATCH net-next 0/3] RTNL: Add link-down reason reporting Andrew Lunn
2019-03-18 12:11 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhpsgw7j.fsf@mellanox.com \
--to=petrm@mellanox$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=tariqt@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox