From: Colin Foster <colin.foster@in-advantage•com>
To: Rob Herring <robh@kernel•org>
Cc: linux-mediatek@lists•infradead.org,
linux-arm-kernel@lists•infradead.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, devicetree@vger•kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"John Crispin" <john@phrozen•org>,
"Sean Wang" <sean.wang@mediatek•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"nç ÜNAL" <arinc.unal@arinc9•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Eric Dumazet" <edumazet@google•com>,
"David S. Miller" <davem@davemloft•net>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro•org>,
"Lee Jones" <lee@kernel•org>
Subject: Re: [PATCH v1 net-next 7/7] dt-bindings: net: mscc,vsc7514-switch: utilize generic ethernet-switch.yaml
Date: Wed, 26 Oct 2022 20:57:02 -0700 [thread overview]
Message-ID: <Y1oBjtQeZlzwMfoD@euler> (raw)
In-Reply-To: <20221026174704.GA809642-robh@kernel.org>
On Wed, Oct 26, 2022 at 12:47:04PM -0500, Rob Herring wrote:
> On Mon, Oct 24, 2022 at 10:03:55PM -0700, Colin Foster wrote:
> > Several bindings for ethernet switches are available for non-dsa switches
> > by way of ethernet-switch.yaml. Remove these duplicate entries and utilize
> > the common bindings for the VSC7514.
> >
> > Signed-off-by: Colin Foster <colin.foster@in-advantage•com>
> > Suggested-by: Vladimir Oltean <olteanv@gmail•com>
> > ---
> > .../bindings/net/mscc,vsc7514-switch.yaml | 36 +------------------
> > 1 file changed, 1 insertion(+), 35 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> > index ee0a504bdb24..1703bd46c3ca 100644
> > --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> > @@ -19,11 +19,8 @@ description: |
> > packet extraction/injection.
> >
> > properties:
> > - $nodename:
> > - pattern: "^switch@[0-9a-f]+$"
> > -
> > compatible:
> > - const: mscc,vsc7514-switch
> > + $ref: ethernet-switch.yaml#
>
> ??? 'compatible' is a node?
I need to look more into this. The compatible string should remain
mscc,vsc7514-switch, but I think the pattern properties should
probably be updated to "^(ethernet-)switch@[0-9a-f]+$" to match
ethernet-switch.yaml.
I didn't think the ethernet-switch.yaml could be at the top level for
the 7514, but I must have been mistaken. Either way - not under
compatible as you're pointing out. Much appreciated.
>
> Rob
prev parent reply other threads:[~2022-10-27 3:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 5:03 [PATCH v1 net-next 0/7] dt-binding preparation for ocelot switches Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 1/7] dt-bindings: mfd: ocelot: remove spi-max-frequency from required properties Colin Foster
2022-10-31 15:36 ` Lee Jones
2022-11-01 2:41 ` Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 2/7] dt-bindings: mfd: ocelot: remove unnecessary driver wording Colin Foster
2022-10-31 15:37 ` Lee Jones
2022-10-25 5:03 ` [PATCH v1 net-next 3/7] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml Colin Foster
2022-10-25 20:05 ` Rob Herring
2022-10-25 21:21 ` Rob Herring
2022-10-27 1:25 ` Vladimir Oltean
2022-10-27 3:35 ` Colin Foster
2022-10-31 15:44 ` Rob Herring
2022-11-01 3:47 ` Colin Foster
2022-10-27 2:44 ` Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 4/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecessary dsa-port reference Colin Foster
2022-10-30 17:42 ` Arınç ÜNAL
2022-11-01 2:40 ` Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 5/7] dt-bindings: net: add generic ethernet-switch Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 6/7] dt-bindings: net: add generic ethernet-switch-port binding Colin Foster
2022-10-26 17:44 ` Rob Herring
2022-10-27 4:06 ` Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 7/7] dt-bindings: net: mscc,vsc7514-switch: utilize generic ethernet-switch.yaml Colin Foster
2022-10-25 20:05 ` Rob Herring
2022-10-25 21:23 ` Rob Herring
2022-10-26 17:47 ` Rob Herring
2022-10-27 3:57 ` Colin Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1oBjtQeZlzwMfoD@euler \
--to=colin.foster@in-advantage$(echo .)com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arinc.unal@arinc9$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sean.wang@mediatek$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox