From: Colin Foster <colin.foster@in-advantage•com>
To: Rob Herring <robh@kernel•org>
Cc: linux-mediatek@lists•infradead.org,
linux-arm-kernel@lists•infradead.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, devicetree@vger•kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"John Crispin" <john@phrozen•org>,
"Sean Wang" <sean.wang@mediatek•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"nç ÜNAL" <arinc.unal@arinc9•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Eric Dumazet" <edumazet@google•com>,
"David S. Miller" <davem@davemloft•net>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro•org>,
"Lee Jones" <lee@kernel•org>
Subject: Re: [PATCH v1 net-next 3/7] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml
Date: Wed, 26 Oct 2022 19:44:46 -0700 [thread overview]
Message-ID: <Y1nwnhjhb06mg0F/@euler> (raw)
In-Reply-To: <20221025212114.GA3322299-robh@kernel.org>
Hi Rob,
On Tue, Oct 25, 2022 at 04:21:14PM -0500, Rob Herring wrote:
> On Mon, Oct 24, 2022 at 10:03:51PM -0700, Colin Foster wrote:
> > The dsa.yaml binding contains duplicated bindings for address and size
> > cells, as well as the reference to dsa-port.yaml. Instead of duplicating
> > this information, remove the reference to dsa-port.yaml and include the
> > full reference to dsa.yaml.
>
> I don't think this works without further restructuring. Essentially,
> 'unevaluatedProperties' on works on a single level. So every level has
> to define all properties at that level either directly in
> properties/patternProperties or within a $ref.
>
> See how graph.yaml is structured and referenced for an example how this
> has to work.
Thanks for pointing me to this. I didn't know about
https://github.com/devicetree-org/dt-schema until now, so I'll take a
look. I was primarily reading the schemas in net/dsa/* to try to get a
full understanding of the DT schema nuances, so these types of nudges
really help me.
And I see that Vladimir Oltean has responded to other parts of the
email, so I'll leave this as a simple "thanks" and keep that context
going forward.
next prev parent reply other threads:[~2022-10-27 2:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 5:03 [PATCH v1 net-next 0/7] dt-binding preparation for ocelot switches Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 1/7] dt-bindings: mfd: ocelot: remove spi-max-frequency from required properties Colin Foster
2022-10-31 15:36 ` Lee Jones
2022-11-01 2:41 ` Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 2/7] dt-bindings: mfd: ocelot: remove unnecessary driver wording Colin Foster
2022-10-31 15:37 ` Lee Jones
2022-10-25 5:03 ` [PATCH v1 net-next 3/7] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml Colin Foster
2022-10-25 20:05 ` Rob Herring
2022-10-25 21:21 ` Rob Herring
2022-10-27 1:25 ` Vladimir Oltean
2022-10-27 3:35 ` Colin Foster
2022-10-31 15:44 ` Rob Herring
2022-11-01 3:47 ` Colin Foster
2022-10-27 2:44 ` Colin Foster [this message]
2022-10-25 5:03 ` [PATCH v1 net-next 4/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecessary dsa-port reference Colin Foster
2022-10-30 17:42 ` Arınç ÜNAL
2022-11-01 2:40 ` Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 5/7] dt-bindings: net: add generic ethernet-switch Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 6/7] dt-bindings: net: add generic ethernet-switch-port binding Colin Foster
2022-10-26 17:44 ` Rob Herring
2022-10-27 4:06 ` Colin Foster
2022-10-25 5:03 ` [PATCH v1 net-next 7/7] dt-bindings: net: mscc,vsc7514-switch: utilize generic ethernet-switch.yaml Colin Foster
2022-10-25 20:05 ` Rob Herring
2022-10-25 21:23 ` Rob Herring
2022-10-26 17:47 ` Rob Herring
2022-10-27 3:57 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1nwnhjhb06mg0F/@euler \
--to=colin.foster@in-advantage$(echo .)com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arinc.unal@arinc9$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sean.wang@mediatek$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox