From: Andrew Lunn <andrew@lunn•ch>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Mengyuan Lou <mengyuanlou@net-swift•com>,
netdev@vger•kernel.org, jiawenwu@trustnetic•com
Subject: Re: [PATCH net-next v7] net: ngbe: Add ngbe mdio bus driver.
Date: Wed, 11 Jan 2023 03:28:11 +0100 [thread overview]
Message-ID: <Y74euxqQUpXR6OGZ@lunn.ch> (raw)
In-Reply-To: <20230110181907.5e4abbcd@kernel.org>
On Tue, Jan 10, 2023 at 06:19:07PM -0800, Jakub Kicinski wrote:
> On Mon, 9 Jan 2023 17:49:12 +0100 Andrew Lunn wrote:
> > On Mon, Jan 09, 2023 at 11:35:08PM +0800, Mengyuan Lou wrote:
> > > Add mdio bus register for ngbe.
> > > The internal phy and external phy need to be handled separately.
> > > Add phy changed event detection.
> > >
> > > Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift•com>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn•ch>
>
> Any preference on this getting merged as is vs Mengyuan implementing
> the c45 support via separate callbacks? I just applied the patches
> adding the new callbacks to net-next:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=ef1757ef58467310a285e57e6dbf6cf8314e5080
Hi Jakub
Thanks for merging these patches. I forget how many patches there are
in total, something like 60, so there are a few more series to
come. Many more drivers still need splitting.
If Mengyuan wants to split C22 and C45 that would be nice, but since
this is a new requirement, i would not insist on it.
Andrew
next prev parent reply other threads:[~2023-01-11 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 15:35 [PATCH net-next v7] net: ngbe: Add ngbe mdio bus driver Mengyuan Lou
2023-01-09 16:49 ` Andrew Lunn
2023-01-11 2:19 ` Jakub Kicinski
2023-01-11 2:28 ` Andrew Lunn [this message]
2023-01-11 2:33 ` mengyuanlou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y74euxqQUpXR6OGZ@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox