From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
netdev@vger•kernel.org, linux-renesas-soc@vger•kernel.org
Subject: Re: [PATCH net-next 1/3] net: phylink: Set host_interfaces for a non-sfp PHY
Date: Tue, 3 Jan 2023 09:54:18 +0000 [thread overview]
Message-ID: <Y7P7Sj/ZJ8V/9Pkq@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221226071425.3895915-2-yoshihiro.shimoda.uh@renesas.com>
On Mon, Dec 26, 2022 at 04:14:23PM +0900, Yoshihiro Shimoda wrote:
> Set phy_dev->host_interfaces by pl->link_interface in
> phylink_fwnode_phy_connect() for a non-sfp PHY.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
> ---
> drivers/net/phy/phylink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 09cc65c0da93..1958d6cc9ef9 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1809,6 +1809,7 @@ int phylink_fwnode_phy_connect(struct phylink *pl,
> pl->link_interface = phy_dev->interface;
> pl->link_config.interface = pl->link_interface;
> }
> + __set_bit(pl->link_interface, phy_dev->host_interfaces);
This is probably going to break Macchiatobin platforms, since we
declare that the link mode there is 10GBASE-R, we'll end up with
host_interfaces containing just this mode. This will cause the
88x3310 driver to select a rate matching interface mode, which the
mvpp2 MAC can't support.
If we want to fill host_interfaces in, then it needs to be filled in
properly - and by that I mean with all the host interface modes that
can be electrically supported - otherwise platforms will break.
So, sorry, but NAK on this change.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-01-03 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 7:14 [PATCH net-next 0/3] net: ethernet: renesas: rswitch: Modify initialization for SERDES and PHY Yoshihiro Shimoda
2022-12-26 7:14 ` [PATCH net-next 1/3] net: phylink: Set host_interfaces for a non-sfp PHY Yoshihiro Shimoda
2023-01-03 9:54 ` Russell King (Oracle) [this message]
2023-01-05 8:00 ` Yoshihiro Shimoda
2022-12-26 7:14 ` [PATCH net-next 2/3] net: ethernet: renesas: rswitch: Simplify struct phy * handling Yoshihiro Shimoda
2022-12-26 7:14 ` [PATCH net-next 3/3] net: ethernet: renesas: rswitch: Add phy_power_{on,off}() calling Yoshihiro Shimoda
2023-01-03 9:56 ` Russell King (Oracle)
2023-01-06 7:34 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7P7Sj/ZJ8V/9Pkq@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox