From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
netdev@vger•kernel.org, linux-renesas-soc@vger•kernel.org
Subject: Re: [PATCH net-next 3/3] net: ethernet: renesas: rswitch: Add phy_power_{on,off}() calling
Date: Tue, 3 Jan 2023 09:56:00 +0000 [thread overview]
Message-ID: <Y7P7sJk4PZ1eLWDZ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221226071425.3895915-4-yoshihiro.shimoda.uh@renesas.com>
On Mon, Dec 26, 2022 at 04:14:25PM +0900, Yoshihiro Shimoda wrote:
> Some Ethernet PHYs (like marvell10g) will decide the host interface
> mode by the media-side speed. So, the rswitch driver needs to
> initialize one of the Ethernet SERDES (r8a779f0-eth-serdes) ports
> after linked the Ethernet PHY up. The r8a779f0-eth-serdes driver has
> .init() for initializing all ports and .power_on() for initializing
> each port. So, add phy_power_{on,off} calling for it.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
> ---
> drivers/net/ethernet/renesas/rswitch.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index ca79ee168206..2f335c95f5a8 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1180,6 +1180,10 @@ static void rswitch_mac_link_down(struct phylink_config *config,
> unsigned int mode,
> phy_interface_t interface)
> {
> + struct net_device *ndev = to_net_dev(config->dev);
> + struct rswitch_device *rdev = netdev_priv(ndev);
> +
> + phy_power_off(rdev->serdes);
> }
>
> static void rswitch_mac_link_up(struct phylink_config *config,
> @@ -1187,7 +1191,11 @@ static void rswitch_mac_link_up(struct phylink_config *config,
> phy_interface_t interface, int speed,
> int duplex, bool tx_pause, bool rx_pause)
> {
> + struct net_device *ndev = to_net_dev(config->dev);
> + struct rswitch_device *rdev = netdev_priv(ndev);
> +
> /* Current hardware cannot change speed at runtime */
> + phy_power_on(rdev->serdes);
> }
>
> static const struct phylink_mac_ops rswitch_phylink_ops = {
This looks to me like it will break anyone using an in-band link,
where the link status comes from the PCS behind the series that
you're now powering down and up.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-01-03 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 7:14 [PATCH net-next 0/3] net: ethernet: renesas: rswitch: Modify initialization for SERDES and PHY Yoshihiro Shimoda
2022-12-26 7:14 ` [PATCH net-next 1/3] net: phylink: Set host_interfaces for a non-sfp PHY Yoshihiro Shimoda
2023-01-03 9:54 ` Russell King (Oracle)
2023-01-05 8:00 ` Yoshihiro Shimoda
2022-12-26 7:14 ` [PATCH net-next 2/3] net: ethernet: renesas: rswitch: Simplify struct phy * handling Yoshihiro Shimoda
2022-12-26 7:14 ` [PATCH net-next 3/3] net: ethernet: renesas: rswitch: Add phy_power_{on,off}() calling Yoshihiro Shimoda
2023-01-03 9:56 ` Russell King (Oracle) [this message]
2023-01-06 7:34 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7P7sJk4PZ1eLWDZ@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox