From: Leon Romanovsky <leon@kernel•org>
To: "Alice Guo (OSS)" <alice.guo@oss•nxp.com>
Cc: gregkh@linuxfoundation•org, rafael@kernel•org,
horia.geanta@nxp•com, aymen.sghaier@nxp•com,
herbert@gondor•apana.org.au, davem@davemloft•net,
tony@atomide•com, geert+renesas@glider•be,
mturquette@baylibre•com, sboyd@kernel•org, vkoul@kernel•org,
peter.ujfalusi@gmail•com, a.hajda@samsung•com,
narmstrong@baylibre•com, robert.foss@linaro•org,
airlied@linux•ie, daniel@ffwll•ch, khilman@baylibre•com,
tomba@kernel•org, jyri.sarha@iki•fi, joro@8bytes•org,
will@kernel•org, mchehab@kernel•org, ulf.hansson@linaro•org,
adrian.hunter@intel•com, kishon@ti•com, kuba@kernel•org,
linus.walleij@linaro•org, Roy.Pledge@nxp•com, leoyang.li@nxp•com,
ssantosh@kernel•org, matthias.bgg@gmail•com, edubezval@gmail•com,
j-keerthy@ti•com, balbi@kernel•org, linux@prisktech•co.nz,
stern@rowland•harvard.edu, wim@linux-watchdog•org,
linux@roeck-us•net, linux-kernel@vger•kernel.org,
linux-crypto@vger•kernel.org, linux-omap@vger•kernel.org,
linux-renesas-soc@vger•kernel.org, linux-clk@vger•kernel.org,
dmaengine@vger•kernel.org, dri-devel@lists•freedesktop.org,
linux-amlogic@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
iommu@lists•linux-foundation.org, linux-media@vger•kernel.org,
linux-mmc@vger•kernel.org, netdev@vger•kernel.org,
linux-phy@lists•infradead.org, linux-gpio@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-staging@lists•linux.dev,
linux-mediatek@lists•infradead.org, linux-pm@vger•kernel.org,
linux-usb@vger•kernel.org, linux-watchdog@vger•kernel.org
Subject: Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match
Date: Mon, 19 Apr 2021 08:02:15 +0300 [thread overview]
Message-ID: <YH0O1104YEdjY9mb@unreal> (raw)
In-Reply-To: <20210419042722.27554-4-alice.guo@oss.nxp.com>
On Mon, Apr 19, 2021 at 12:27:22PM +0800, Alice Guo (OSS) wrote:
> From: Alice Guo <alice.guo@nxp•com>
>
> Update all the code that use soc_device_match because add support for
> soc_device_match returning -EPROBE_DEFER.
>
> Signed-off-by: Alice Guo <alice.guo@nxp•com>
> ---
> drivers/bus/ti-sysc.c | 2 +-
> drivers/clk/renesas/r8a7795-cpg-mssr.c | 4 +++-
> drivers/clk/renesas/rcar-gen2-cpg.c | 2 +-
> drivers/clk/renesas/rcar-gen3-cpg.c | 2 +-
> drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c | 7 ++++++-
> drivers/dma/ti/k3-psil.c | 3 +++
> drivers/dma/ti/k3-udma.c | 2 +-
> drivers/gpu/drm/bridge/nwl-dsi.c | 2 +-
> drivers/gpu/drm/meson/meson_drv.c | 4 +++-
> drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +-
> drivers/gpu/drm/omapdrm/dss/dpi.c | 4 +++-
> drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +++
> drivers/gpu/drm/omapdrm/dss/dss.c | 3 +++
> drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 3 +++
> drivers/gpu/drm/omapdrm/dss/venc.c | 4 +++-
> drivers/gpu/drm/omapdrm/omap_drv.c | 3 +++
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 +++-
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +-
> drivers/gpu/drm/tidss/tidss_dispc.c | 4 +++-
> drivers/iommu/ipmmu-vmsa.c | 7 +++++--
> drivers/media/platform/rcar-vin/rcar-core.c | 2 +-
> drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +-
> drivers/media/platform/vsp1/vsp1_uif.c | 4 +++-
> drivers/mmc/host/renesas_sdhi_core.c | 2 +-
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 2 +-
> drivers/mmc/host/sdhci-of-esdhc.c | 21 ++++++++++++++-----
> drivers/mmc/host/sdhci-omap.c | 2 +-
> drivers/mmc/host/sdhci_am654.c | 2 +-
> drivers/net/ethernet/renesas/ravb_main.c | 4 +++-
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
> drivers/net/ethernet/ti/cpsw.c | 2 +-
> drivers/net/ethernet/ti/cpsw_new.c | 2 +-
> drivers/phy/ti/phy-omap-usb2.c | 4 +++-
> drivers/pinctrl/renesas/core.c | 2 +-
> drivers/pinctrl/renesas/pfc-r8a7790.c | 5 ++++-
> drivers/pinctrl/renesas/pfc-r8a7794.c | 5 ++++-
> drivers/soc/fsl/dpio/dpio-driver.c | 13 ++++++++----
> drivers/soc/renesas/r8a774c0-sysc.c | 5 ++++-
> drivers/soc/renesas/r8a7795-sysc.c | 2 +-
> drivers/soc/renesas/r8a77990-sysc.c | 5 ++++-
> drivers/soc/ti/k3-ringacc.c | 2 +-
> drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
> drivers/thermal/rcar_gen3_thermal.c | 4 +++-
> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 10 +++++++--
> drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
> drivers/usb/host/ehci-platform.c | 4 +++-
> drivers/usb/host/xhci-rcar.c | 2 +-
> drivers/watchdog/renesas_wdt.c | 2 +-
> 48 files changed, 131 insertions(+), 52 deletions(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> index 5fae60f8c135..00c59aa217c1 100644
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2909,7 +2909,7 @@ static int sysc_init_soc(struct sysc *ddata)
> }
>
> match = soc_device_match(sysc_soc_feat_match);
> - if (!match)
> + if (!match || IS_ERR(match))
> return 0;
>
> if (match->data)
> diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> index c32d2c678046..90a18336a4c3 100644
> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -439,6 +439,7 @@ static const unsigned int r8a7795es2_mod_nullify[] __initconst = {
>
> static int __init r8a7795_cpg_mssr_init(struct device *dev)
> {
> + const struct soc_device_attribute *match;
> const struct rcar_gen3_cpg_pll_config *cpg_pll_config;
> u32 cpg_mode;
> int error;
> @@ -453,7 +454,8 @@ static int __init r8a7795_cpg_mssr_init(struct device *dev)
> return -EINVAL;
> }
>
> - if (soc_device_match(r8a7795es1)) {
> + match = soc_device_match(r8a7795es1);
> + if (!IS_ERR(match) && match) {
"if (!IS_ERR_OR_NULL(match))" in all places.
Thanks
next prev parent reply other threads:[~2021-04-19 5:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 4:27 [RFC v1 PATCH 0/3] support soc_device_match to return -EPROBE_DEFER Alice Guo (OSS)
2021-04-19 4:27 ` [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Alice Guo (OSS)
2021-04-19 4:49 ` Dominique MARTINET
2021-04-19 6:40 ` Alice Guo (OSS)
2021-04-19 8:20 ` Geert Uytterhoeven
2021-04-20 11:21 ` Dan Carpenter
2021-04-19 4:27 ` [RFC v1 PATCH 2/3] caam: add defer probe when the caam driver cannot identify SoC Alice Guo (OSS)
2021-04-19 4:27 ` [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match Alice Guo (OSS)
2021-04-19 5:02 ` Leon Romanovsky [this message]
2021-04-19 6:46 ` Alice Guo (OSS)
2021-04-19 5:02 ` Dominique MARTINET
2021-04-19 7:09 ` Alice Guo (OSS)
2021-04-19 9:03 ` Geert Uytterhoeven
2021-04-19 9:33 ` Dominique MARTINET
2021-04-19 12:16 ` Arnd Bergmann
2021-04-19 23:42 ` Dominique MARTINET
2021-04-20 9:07 ` Arnd Bergmann
2021-04-20 9:10 ` Arnd Bergmann
2021-04-19 13:36 ` Guenter Roeck
2021-04-20 9:40 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH0O1104YEdjY9mb@unreal \
--to=leon@kernel$(echo .)org \
--cc=Roy.Pledge@nxp$(echo .)com \
--cc=a.hajda@samsung$(echo .)com \
--cc=adrian.hunter@intel$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=alice.guo@oss$(echo .)nxp.com \
--cc=aymen.sghaier@nxp$(echo .)com \
--cc=balbi@kernel$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=edubezval@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=horia.geanta@nxp$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=j-keerthy@ti$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=jyri.sarha@iki$(echo .)fi \
--cc=khilman@baylibre$(echo .)com \
--cc=kishon@ti$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@prisktech$(echo .)co.nz \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mturquette@baylibre$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.ujfalusi@gmail$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=robert.foss@linaro$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=ssantosh@kernel$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=tomba@kernel$(echo .)org \
--cc=tony@atomide$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox