From: Dominique MARTINET <dominique.martinet@atmark-techno•com>
To: "Alice Guo (OSS)" <alice.guo@oss•nxp.com>
Cc: gregkh@linuxfoundation•org, rafael@kernel•org,
horia.geanta@nxp•com, aymen.sghaier@nxp•com,
herbert@gondor•apana.org.au, davem@davemloft•net,
tony@atomide•com, geert+renesas@glider•be,
mturquette@baylibre•com, sboyd@kernel•org, vkoul@kernel•org,
peter.ujfalusi@gmail•com, a.hajda@samsung•com,
narmstrong@baylibre•com, robert.foss@linaro•org,
airlied@linux•ie, daniel@ffwll•ch, khilman@baylibre•com,
tomba@kernel•org, jyri.sarha@iki•fi, joro@8bytes•org,
will@kernel•org, mchehab@kernel•org, ulf.hansson@linaro•org,
adrian.hunter@intel•com, kishon@ti•com, kuba@kernel•org,
linus.walleij@linaro•org, Roy.Pledge@nxp•com, leoyang.li@nxp•com,
ssantosh@kernel•org, matthias.bgg@gmail•com, edubezval@gmail•com,
j-keerthy@ti•com, balbi@kernel•org, linux@prisktech•co.nz,
stern@rowland•harvard.edu, wim@linux-watchdog•org,
linux@roeck-us•net, linux-kernel@vger•kernel.org,
linux-crypto@vger•kernel.org, linux-omap@vger•kernel.org,
linux-renesas-soc@vger•kernel.org, linux-clk@vger•kernel.org,
dmaengine@vger•kernel.org, dri-devel@lists•freedesktop.org,
linux-amlogic@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
iommu@lists•linux-foundation.org, linux-media@vger•kernel.org,
linux-mmc@vger•kernel.org, netdev@vger•kernel.org,
linux-phy@lists•infradead.org, linux-gpio@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-staging@lists•linux.dev,
linux-mediatek@lists•infradead.org, linux-pm@vger•kernel.org,
linux-usb@vger•kernel.org, linux-watchdog@vger•kernel.org
Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER
Date: Mon, 19 Apr 2021 13:49:07 +0900 [thread overview]
Message-ID: <YH0Lwy2AYpXaJIex@atmark-techno.com> (raw)
In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com>
First comment overall for the whole serie:
Since it is the solution I had suggested when I reported the problem[1]
I have no qualm on the approach, comments for individual patches
follow.
[1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com
Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800:
> From: Alice Guo <alice.guo@nxp•com>
>
> In i.MX8M boards, the registration of SoC device is later than caam
> driver which needs it. Caam driver needs soc_device_match to provide
> -EPROBE_DEFER when no SoC device is registered and no
> early_soc_dev_attr.
This patch should be last in the set: you can't have soc_device_match
return an error before its callers handle it.
> Signed-off-by: Alice Guo <alice.guo@nxp•com>
As the one who reported the problem I would have been appreciated being
at least added to Ccs... I only happened to notice you posted this by
chance.
There is also not a single Fixes tag -- I believe this commit should
have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver")
but I'm not sure how such tags should be handled in case of multiple
patches fixing something.
--
Dominique
next prev parent reply other threads:[~2021-04-19 4:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 4:27 [RFC v1 PATCH 0/3] support soc_device_match to return -EPROBE_DEFER Alice Guo (OSS)
2021-04-19 4:27 ` [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Alice Guo (OSS)
2021-04-19 4:49 ` Dominique MARTINET [this message]
2021-04-19 6:40 ` Alice Guo (OSS)
2021-04-19 8:20 ` Geert Uytterhoeven
2021-04-20 11:21 ` Dan Carpenter
2021-04-19 4:27 ` [RFC v1 PATCH 2/3] caam: add defer probe when the caam driver cannot identify SoC Alice Guo (OSS)
2021-04-19 4:27 ` [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match Alice Guo (OSS)
2021-04-19 5:02 ` Leon Romanovsky
2021-04-19 6:46 ` Alice Guo (OSS)
2021-04-19 5:02 ` Dominique MARTINET
2021-04-19 7:09 ` Alice Guo (OSS)
2021-04-19 9:03 ` Geert Uytterhoeven
2021-04-19 9:33 ` Dominique MARTINET
2021-04-19 12:16 ` Arnd Bergmann
2021-04-19 23:42 ` Dominique MARTINET
2021-04-20 9:07 ` Arnd Bergmann
2021-04-20 9:10 ` Arnd Bergmann
2021-04-19 13:36 ` Guenter Roeck
2021-04-20 9:40 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH0Lwy2AYpXaJIex@atmark-techno.com \
--to=dominique.martinet@atmark-techno$(echo .)com \
--cc=Roy.Pledge@nxp$(echo .)com \
--cc=a.hajda@samsung$(echo .)com \
--cc=adrian.hunter@intel$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=alice.guo@oss$(echo .)nxp.com \
--cc=aymen.sghaier@nxp$(echo .)com \
--cc=balbi@kernel$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=edubezval@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=horia.geanta@nxp$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=j-keerthy@ti$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=jyri.sarha@iki$(echo .)fi \
--cc=khilman@baylibre$(echo .)com \
--cc=kishon@ti$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@prisktech$(echo .)co.nz \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mturquette@baylibre$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.ujfalusi@gmail$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=robert.foss@linaro$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=ssantosh@kernel$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=tomba@kernel$(echo .)org \
--cc=tony@atomide$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox