From: Andrew Lunn <andrew@lunn•ch>
To: Liang Xu <lxu@maxlinear•com>
Cc: "hkallweit1@gmail•com" <hkallweit1@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"kuba@kernel•org" <kuba@kernel•org>,
"vee.khee.wong@linux•intel.com" <vee.khee.wong@linux•intel.com>,
"linux@armlinux•org.uk" <linux@armlinux•org.uk>,
Hauke Mehrtens <hmehrtens@maxlinear•com>,
Thomas Mohren <tmohren@maxlinear•com>,
"mohammad.athari.ismail@intel•com"
<mohammad.athari.ismail@intel•com>
Subject: Re: [PATCH v6 2/2] net: phy: add Maxlinear GPY115/21x/24x driver
Date: Tue, 20 Jul 2021 15:02:23 +0200 [thread overview]
Message-ID: <YPbJX34DG5gYFkEq@lunn.ch> (raw)
In-Reply-To: <c21ac03c-28dc-1bb1-642a-ba309e39c08b@maxlinear.com>
On Tue, Jul 20, 2021 at 03:35:17AM +0000, Liang Xu wrote:
> On 20/7/2021 4:48 am, Andrew Lunn wrote:
> > This email was sent from outside of MaxLinear.
> >
> >
> >> +/* PHY ID */
> >> +#define PHY_ID_GPYx15B_MASK 0xFFFFFFFC
> >> +#define PHY_ID_GPY21xB_MASK 0xFFFFFFF9
> > That is an odd mask. Is that really correct?
> >
> > Andrew
> >
> Hi Andrew,
>
>
> Yes, this is correct and has been tested.
>
> It's special because of a PHY ID scheme change during manufacturing.
O.K. It is just a really odd mask. And putting the revision in the
middle, not at the end? And none of the IDs have bit 0 set. It just
all adds up to it looking wrong. So i had to ask.
Andrew
next prev parent reply other threads:[~2021-07-20 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 5:32 [PATCH v6 1/2] net: phy: add API to read 802.3-c45 IDs Xu Liang
2021-07-19 5:32 ` [PATCH v6 2/2] net: phy: add Maxlinear GPY115/21x/24x driver Xu Liang
2021-07-19 18:30 ` Hauke Mehrtens
2021-07-19 20:48 ` Andrew Lunn
2021-07-20 3:35 ` Liang Xu
2021-07-20 13:02 ` Andrew Lunn [this message]
2021-07-20 13:18 ` Liang Xu
2021-07-20 0:58 ` Wong Vee Khee
2021-07-20 1:03 ` Wong Vee Khee
2021-07-20 14:11 ` Andrew Lunn
2021-07-19 18:30 ` [PATCH v6 1/2] net: phy: add API to read 802.3-c45 IDs Hauke Mehrtens
2021-07-19 20:40 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPbJX34DG5gYFkEq@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=hmehrtens@maxlinear$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=lxu@maxlinear$(echo .)com \
--cc=mohammad.athari.ismail@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tmohren@maxlinear$(echo .)com \
--cc=vee.khee.wong@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox