* [PATCH v2] net: usb: pegasus: fixes of set_register(s) return value evaluation;
@ 2021-08-20 6:57 Petko Manolov
2021-08-20 14:00 ` patchwork-bot+netdevbpf
2021-08-21 11:47 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Petko Manolov @ 2021-08-20 6:57 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, paskripkin, stable, Petko Manolov
- restore the behavior in enable_net_traffic() to avoid regressions - Jakub
Kicinski;
- hurried up and removed redundant assignment in pegasus_open() before yet
another checker complains;
Fixes: 8a160e2e9aeb ("net: usb: pegasus: Check the return value of get_geristers() and friends;")
Reported-by: Jakub Kicinski <kuba@kernel•org>
Signed-off-by: Petko Manolov <petko.manolov@konsulko•com>
---
drivers/net/usb/pegasus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index 652e9fcf0b77..9f9dd0de33cb 100644
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -446,7 +446,7 @@ static int enable_net_traffic(struct net_device *dev, struct usb_device *usb)
write_mii_word(pegasus, 0, 0x1b, &auxmode);
}
- return 0;
+ return ret;
fail:
netif_dbg(pegasus, drv, pegasus->net, "%s failed\n", __func__);
return ret;
@@ -835,7 +835,7 @@ static int pegasus_open(struct net_device *net)
if (!pegasus->rx_skb)
goto exit;
- res = set_registers(pegasus, EthID, 6, net->dev_addr);
+ set_registers(pegasus, EthID, 6, net->dev_addr);
usb_fill_bulk_urb(pegasus->rx_urb, pegasus->usb,
usb_rcvbulkpipe(pegasus->usb, 1),
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] net: usb: pegasus: fixes of set_register(s) return value evaluation;
2021-08-20 6:57 [PATCH v2] net: usb: pegasus: fixes of set_register(s) return value evaluation; Petko Manolov
@ 2021-08-20 14:00 ` patchwork-bot+netdevbpf
2021-08-21 11:47 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-20 14:00 UTC (permalink / raw)
To: Petko Manolov; +Cc: davem, netdev, kuba, paskripkin, stable
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 20 Aug 2021 09:57:53 +0300 you wrote:
> - restore the behavior in enable_net_traffic() to avoid regressions - Jakub
> Kicinski;
> - hurried up and removed redundant assignment in pegasus_open() before yet
> another checker complains;
>
> Fixes: 8a160e2e9aeb ("net: usb: pegasus: Check the return value of get_geristers() and friends;")
> Reported-by: Jakub Kicinski <kuba@kernel•org>
> Signed-off-by: Petko Manolov <petko.manolov@konsulko•com>
>
> [...]
Here is the summary with links:
- [v2] net: usb: pegasus: fixes of set_register(s) return value evaluation;
https://git.kernel.org/netdev/net/c/ffc9c3ebb4af
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] net: usb: pegasus: fixes of set_register(s) return value evaluation;
2021-08-20 6:57 [PATCH v2] net: usb: pegasus: fixes of set_register(s) return value evaluation; Petko Manolov
2021-08-20 14:00 ` patchwork-bot+netdevbpf
@ 2021-08-21 11:47 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-08-21 11:47 UTC (permalink / raw)
To: Petko Manolov; +Cc: davem, netdev, kuba, paskripkin, stable
On Fri, Aug 20, 2021 at 09:57:53AM +0300, Petko Manolov wrote:
> - restore the behavior in enable_net_traffic() to avoid regressions - Jakub
> Kicinski;
> - hurried up and removed redundant assignment in pegasus_open() before yet
> another checker complains;
>
> Fixes: 8a160e2e9aeb ("net: usb: pegasus: Check the return value of get_geristers() and friends;")
> Reported-by: Jakub Kicinski <kuba@kernel•org>
> Signed-off-by: Petko Manolov <petko.manolov@konsulko•com>
> ---
> drivers/net/usb/pegasus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-21 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-20 6:57 [PATCH v2] net: usb: pegasus: fixes of set_register(s) return value evaluation; Petko Manolov
2021-08-20 14:00 ` patchwork-bot+netdevbpf
2021-08-21 11:47 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox