From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>, Heiner Kallweit <hkallweit1@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Marcin Wojtas <mw@semihalf•com>,
netdev@vger•kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>
Subject: [PATCH net-next 0/3] introduce generic phylink validation
Date: Mon, 15 Nov 2021 09:59:57 +0000 [thread overview]
Message-ID: <YZIvnerLwnMkxx3p@shell.armlinux.org.uk> (raw)
Hi,
The various validate method implementations we have in phylink users
have been quite repetitive but also prone to bugs. These patches
introduce a generic implementation which relies solely on the
supported_interfaces bitmap introduced during last cycle, and in the
first patch, a bit array of MAC capabilities.
MAC drivers are free to continue to do their own thing if they have
special requirements - such as mvneta and mvpp2 which do not support
1000base-X without AN enabled. Most implementations currently in the
kernel can be converted to call phylink_generic_validate() directly
from the phylink MAC operations structure once they fill in the
supported_interfaces and mac_capabilities members of phylink_config.
This series introduces the generic implementation, and converts mvneta
and mvpp2 to use it.
drivers/net/ethernet/marvell/mvneta.c | 34 +---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 58 +-----
drivers/net/phy/phylink.c | 252 ++++++++++++++++++++++++
include/linux/phylink.h | 31 +++
4 files changed, 296 insertions(+), 79 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2021-11-15 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:59 Russell King (Oracle) [this message]
2021-11-15 10:00 ` [PATCH net-next 1/3] net: phylink: add generic validate implementation Russell King (Oracle)
2021-11-15 19:54 ` Andrew Lunn
2021-11-15 20:10 ` Russell King (Oracle)
2021-11-15 10:00 ` [PATCH net-next 2/3] net: mvneta: use phylink_generic_validate() Russell King (Oracle)
2021-11-15 10:00 ` [PATCH net-next 3/3] net: mvpp2: " Russell King (Oracle)
2021-11-15 14:50 ` [PATCH net-next 0/3] introduce generic phylink validation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZIvnerLwnMkxx3p@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox