From: Andrew Lunn <andrew@lunn•ch>
To: Kai-Heng Feng <kai.heng.feng@canonical•com>
Cc: peppe.cavallaro@st•com, alexandre.torgue@foss•st.com,
joabreu@synopsys•com, "David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Russell King" <linux@armlinux•org.uk>,
"Marek Behún" <kabel@kernel•org>,
"Ivan Bornyakov" <i.bornyakov@metrotek•ru>,
"Pali Rohár" <pali@kernel•org>,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware
Date: Fri, 14 Jan 2022 14:20:17 +0100 [thread overview]
Message-ID: <YeF4kbsqag+kZ7ji@lunn.ch> (raw)
In-Reply-To: <20220114040755.1314349-2-kai.heng.feng@canonical.com>
> static void marvell_config_led(struct phy_device *phydev)
> {
> - u16 def_config;
> + struct marvell_priv *priv = phydev->priv;
> int err;
>
> - switch (MARVELL_PHY_FAMILY_ID(phydev->phy_id)) {
> - /* Default PHY LED config: LED[0] .. Link, LED[1] .. Activity */
> - case MARVELL_PHY_FAMILY_ID(MARVELL_PHY_ID_88E1121R):
> - case MARVELL_PHY_FAMILY_ID(MARVELL_PHY_ID_88E1318S):
> - def_config = MII_88E1121_PHY_LED_DEF;
> - break;
> - /* Default PHY LED config:
> - * LED[0] .. 1000Mbps Link
> - * LED[1] .. 100Mbps Link
> - * LED[2] .. Blink, Activity
> - */
> - case MARVELL_PHY_FAMILY_ID(MARVELL_PHY_ID_88E1510):
> - if (phydev->dev_flags & MARVELL_PHY_LED0_LINK_LED1_ACTIVE)
> - def_config = MII_88E1510_PHY_LED0_LINK_LED1_ACTIVE;
> - else
> - def_config = MII_88E1510_PHY_LED_DEF;
> - break;
> - default:
> + if (priv->led_def_config == -1)
> return;
> +
> + if (priv->led_def_config)
> + goto write;
Really?
Please restructure this code. Take it apart into helpers. You need:
A function to set the actual LED configuration.
A function to decide what, if any, configuration to set
A function to store the current configuration on suspend.
A function to restore the current configuration on resume.
Lots of little functions will make it much easier to understand, and
avoid 1980s BASIC style.
I'm also surprised you need to deal with suspend/resume. Why does the
BIOS not set the LED mode on resume, same as it does on power up?
Andrew
next prev parent reply other threads:[~2022-01-14 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220114040755.1314349-1-kai.heng.feng@canonical.com>
2022-01-14 4:07 ` [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware Kai-Heng Feng
2022-01-14 4:35 ` Jakub Kicinski
2022-01-14 6:47 ` Kai-Heng Feng
2022-01-14 16:23 ` Jakub Kicinski
2022-01-14 13:09 ` Andrew Lunn
2022-01-14 15:22 ` Kai-Heng Feng
2022-01-14 17:25 ` Andrew Lunn
2022-01-14 13:20 ` Andrew Lunn [this message]
2022-01-14 15:25 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeF4kbsqag+kZ7ji@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=i.bornyakov@metrotek$(echo .)ru \
--cc=joabreu@synopsys$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=kai.heng.feng@canonical$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pali@kernel$(echo .)org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox