From: Andrew Lunn <andrew@lunn•ch>
To: Kai-Heng Feng <kai.heng.feng@canonical•com>
Cc: peppe.cavallaro@st•com, alexandre.torgue@foss•st.com,
joabreu@synopsys•com, "David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Russell King" <linux@armlinux•org.uk>,
"Marek Behún" <kabel@kernel•org>,
"Ivan Bornyakov" <i.bornyakov@metrotek•ru>,
"Pali Rohár" <pali@kernel•org>,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware
Date: Fri, 14 Jan 2022 18:25:41 +0100 [thread overview]
Message-ID: <YeGyFabsBAfzvnU+@lunn.ch> (raw)
In-Reply-To: <CAAd53p5R2y-2JhWx3wp2=aBypJO=iV7fFS99eAgk6q7KBZMFMA@mail.gmail.com>
> > This is a PHY property. Why is the MAC involved?
>
> This is inspired by commit a93f7fe13454 ("net: phy: marvell: add new
> default led configure for m88e151x") which passes the flag from MAC to
> PHY.
But in this case, the MAC does not care what the LEDs are. The
platform wants them left alone, not the MAC.
> > Please also think about how to make this generic, so any ACPI based
> > system can use it, with any PHY.
...
> So the only approach I can think of is to use DMI match directly in PHY driver.
In the phylib core. And the core then asks the specific PHY driver to
not touch the LED configuration. It is then generic.
Andrew
next prev parent reply other threads:[~2022-01-14 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220114040755.1314349-1-kai.heng.feng@canonical.com>
2022-01-14 4:07 ` [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware Kai-Heng Feng
2022-01-14 4:35 ` Jakub Kicinski
2022-01-14 6:47 ` Kai-Heng Feng
2022-01-14 16:23 ` Jakub Kicinski
2022-01-14 13:09 ` Andrew Lunn
2022-01-14 15:22 ` Kai-Heng Feng
2022-01-14 17:25 ` Andrew Lunn [this message]
2022-01-14 13:20 ` Andrew Lunn
2022-01-14 15:25 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeGyFabsBAfzvnU+@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=i.bornyakov@metrotek$(echo .)ru \
--cc=joabreu@synopsys$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=kai.heng.feng@canonical$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pali@kernel$(echo .)org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox