* [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig
@ 2022-06-22 14:31 Paolo Abeni
2022-06-22 14:35 ` Russell King (Oracle)
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Abeni @ 2022-06-22 14:31 UTC (permalink / raw)
To: netdev
Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Ong Boon Leong,
Russell King (Oracle)
This is another attempt at fixing:
>> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
We can't mix select and depends, or that will trigger a circular dependency.
We can't use 'depends on' for PHYLINK, as the latter config is not
user-visible.
Pull-in all the dependencies via 'select'.
Note that PHYLINK already selects PHYLIB, which in turn selects MDIO_DEVICE.
v1 -> v2:
- use 'select' instead of 'depends on' (Jakub)
Link: https://lore.kernel.org/netdev/20220621125045.7e0a78c2@kernel.org/
Reported-by: kernel test robot <lkp@intel•com>
Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Signed-off-by: Paolo Abeni <pabeni@redhat•com>
---
drivers/net/pcs/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
index 22ba7b0b476d..59148d9654d5 100644
--- a/drivers/net/pcs/Kconfig
+++ b/drivers/net/pcs/Kconfig
@@ -7,7 +7,8 @@ menu "PCS device drivers"
config PCS_XPCS
tristate "Synopsys DesignWare XPCS controller"
- depends on MDIO_DEVICE && MDIO_BUS
+ select MDIO_BUS
+ select PHYLINK
help
This module provides helper functions for Synopsys DesignWare XPCS
controllers.
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig
2022-06-22 14:31 [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig Paolo Abeni
@ 2022-06-22 14:35 ` Russell King (Oracle)
0 siblings, 0 replies; 2+ messages in thread
From: Russell King (Oracle) @ 2022-06-22 14:35 UTC (permalink / raw)
To: Paolo Abeni
Cc: netdev, Andrew Lunn, Heiner Kallweit, David S. Miller,
Eric Dumazet, Jakub Kicinski, Ong Boon Leong
On Wed, Jun 22, 2022 at 04:31:56PM +0200, Paolo Abeni wrote:
> This is another attempt at fixing:
>
> >> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> >> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>
> We can't mix select and depends, or that will trigger a circular dependency.
> We can't use 'depends on' for PHYLINK, as the latter config is not
> user-visible.
> Pull-in all the dependencies via 'select'.
> Note that PHYLINK already selects PHYLIB, which in turn selects MDIO_DEVICE.
>
> v1 -> v2:
> - use 'select' instead of 'depends on' (Jakub)
Why? I'm failing to understand the rationale here. See my reply to
Jakub sent a few minutes ago.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-22 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-22 14:31 [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig Paolo Abeni
2022-06-22 14:35 ` Russell King (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox