From: Simon Horman <simon.horman@corigine•com>
To: Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing the ranges
Date: Wed, 22 Mar 2023 17:46:53 +0100 [thread overview]
Message-ID: <ZBsw/SRtCgfadtlC@corigine.com> (raw)
In-Reply-To: <20230321232831.1200905-1-vladimir.oltean@nxp.com>
On Wed, Mar 22, 2023 at 01:28:31AM +0200, Vladimir Oltean wrote:
> When running "ethtool -S eno0 --groups rmon" without an explicit "--src
> emac|pmac" argument, the kernel will not report
> rx-rmon-etherStatsPkts64to64Octets, rx-rmon-etherStatsPkts65to127Octets,
> etc. This is because on ETHTOOL_MAC_STATS_SRC_AGGREGATE, we do not
> populate the "ranges" argument.
>
> ocelot_port_get_rmon_stats() does things differently and things work
> there. I had forgotten to make sure that the code is structured the same
> way in both drivers, so do that now.
>
> Fixes: cf52bd238b75 ("net: enetc: add support for MAC Merge statistics counters")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp•com>
This feels a bit more like an enhancement than a fix to me,
but I don't feel strongly about it.
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-03-22 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 23:28 [PATCH net] net: enetc: fix aggregate RMON counters not showing the ranges Vladimir Oltean
2023-03-22 16:46 ` Simon Horman [this message]
2023-03-22 16:51 ` Vladimir Oltean
2023-03-22 16:53 ` Simon Horman
2023-03-23 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBsw/SRtCgfadtlC@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox