From: Simon Horman <simon.horman@corigine•com>
To: Konstantin Khorenko <khorenko@virtuozzo•com>
Cc: netdev@vger•kernel.org, Jakub Kicinski <kuba@kernel•org>,
Manish Chopra <manishc@marvell•com>,
Ariel Elior <aelior@marvell•com>,
David Miller <davem@davemloft•net>,
Sudarsana Kalluru <skalluru@marvell•com>,
Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH 1/1] qed: Fix scheduling in a tasklet while getting stats
Date: Thu, 27 Jul 2023 13:59:10 +0200 [thread overview]
Message-ID: <ZMJcDvPrz1pEBPft@corigine.com> (raw)
In-Reply-To: <20230726171930.1632710-2-khorenko@virtuozzo.com>
On Wed, Jul 26, 2023 at 08:19:30PM +0300, Konstantin Khorenko wrote:
...
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iscsi.h b/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> index dec2b00259d4..7d8d6ad7faa9 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> @@ -43,7 +43,8 @@ void qed_iscsi_free(struct qed_hwfn *p_hwfn);
> * Return: Void.
> */
> void qed_get_protocol_stats_iscsi(struct qed_dev *cdev,
> - struct qed_mcp_iscsi_stats *stats);
> + struct qed_mcp_iscsi_stats *stats,
> + bool is_atomic);
Hi Konstantin,
Please add is_atomic to the kernel doc for qed_get_protocol_stats_iscsi,
which is immediately above this function declaration.
> #else /* IS_ENABLED(CONFIG_QED_ISCSI) */
> static inline int qed_iscsi_alloc(struct qed_hwfn *p_hwfn)
> {
> @@ -56,7 +57,8 @@ static inline void qed_iscsi_free(struct qed_hwfn *p_hwfn) {}
>
> static inline void
> qed_get_protocol_stats_iscsi(struct qed_dev *cdev,
> - struct qed_mcp_iscsi_stats *stats) {}
> + struct qed_mcp_iscsi_stats *stats,
> + bool is_atomic) {}
> #endif /* IS_ENABLED(CONFIG_QED_ISCSI) */
>
> #endif
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-07-27 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 17:19 [PATCH 0/1] qed: Yet another scheduling while atomic fix Konstantin Khorenko
2023-07-26 17:19 ` [PATCH 1/1] qed: Fix scheduling in a tasklet while getting stats Konstantin Khorenko
2023-07-27 11:59 ` Simon Horman [this message]
2023-07-27 15:26 ` [PATCH v2 0/1] qed: Yet another scheduling while atomic fix Konstantin Khorenko
2023-07-27 15:26 ` [PATCH v2 1/1] qed: Fix scheduling in a tasklet while getting stats Konstantin Khorenko
2023-07-29 11:07 ` Simon Horman
2023-07-29 16:20 ` [PATCH v2 0/1] qed: Yet another scheduling while atomic fix patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMJcDvPrz1pEBPft@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=khorenko@virtuozzo$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=manishc@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=skalluru@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox